[jira] [Commented] (SLING-5757) NonExistingResource.getParent() should not return null in case the parent is non-existing

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313626#comment-15313626 ] 

Carsten Ziegeler commented on SLING-5757:
-----------------------------------------

Patch looks good, I'm not so happy with adding a dependency on the mock implementation. I think using some plain mocks should do the trick

> NonExistingResource.getParent() should not return null in case the parent is non-existing
> -----------------------------------------------------------------------------------------
>
>                 Key: SLING-5757
>                 URL: https://issues.apache.org/jira/browse/SLING-5757
>             Project: Sling
>          Issue Type: Bug
>          Components: API
>    Affects Versions: API 2.11.0
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>         Attachments: SLING-5757-v01.patch
>
>
> Currently {{NonExistingResource.getParent()}} returns {{null}} in case the parent does not exist either. According to the javadoc of {{Resource.getParent()}}  {{null}} should only be returned when the current resource is already the root resource. 
> Therefore {{NonExistingResource.getParent()}} should rather return a {{NonExistingResource}} as well, in case the parent does not exist.
> Compare with the discussion at http://www.mail-archive.com/dev@sling.apache.org/msg56294.html.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)