You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "JoshRosen (via GitHub)" <gi...@apache.org> on 2024/05/31 21:55:30 UTC
[PR] [SPARK-48496][CORE] [spark]
JoshRosen opened a new pull request, #46829:
URL: https://github.com/apache/spark/pull/46829
### What changes were proposed in this pull request?
This PR updates `JavaUtils.timeStringAs` and `JavaUtils.byteStringAs` to use static `Pattern` instances instead of recompiling the regexes on every call.
### Why are the changes needed?
Tiny perf. optimization. This isn't a huge overhead in the grand scheme of things, but it surfaced during some other profiling work and is straightforward to address via static Pattern instances.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48496][CORE] Use static regex Pattern instances in JavaUtils.timeStringAs and JavaUtils.byteStringAs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #46829: [SPARK-48496][CORE] Use static regex Pattern instances in JavaUtils.timeStringAs and JavaUtils.byteStringAs
URL: https://github.com/apache/spark/pull/46829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48496][CORE] Use static regex Pattern instances in JavaUtils.timeStringAs and JavaUtils.byteStringAs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46829:
URL: https://github.com/apache/spark/pull/46829#issuecomment-2144144870
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org