You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/22 04:07:58 UTC
[GitHub] [incubator-doris] Skysheepwang opened a new pull request #5113: Fix old tablet inserting bug
Skysheepwang opened a new pull request #5113:
URL: https://github.com/apache/incubator-doris/pull/5113
## Proposed changes
#4996
When BE is restarting and the older tablet have been added to the garbage collection queue but not deleted yet.
In this case, since the data_dirs are parallel loaded, a later loaded tablet may be older than previously loaded one, which should not be acknowledged as a failure.
It should be noted that the `_add_tablet_unlocked()` method will also be called when creating a new tablet. In that case, the changes in this pull request will not be accessed so there is no affect on the tablet creating process.
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #4996), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #5113: [Bug] Fix old tablet inserting bug
Posted by GitBox <gi...@apache.org>.
imay merged pull request #5113:
URL: https://github.com/apache/incubator-doris/pull/5113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #5113: [Bug] Fix old tablet inserting bug
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #5113:
URL: https://github.com/apache/incubator-doris/pull/5113#discussion_r547080418
##########
File path: be/src/olap/olap_define.h
##########
@@ -189,11 +189,12 @@ enum OLAPStatus {
// StorageEngine
// [-500, -600)
OLAP_ERR_ENGINE_INSERT_EXISTS_TABLE = -500,
- OLAP_ERR_ENGINE_DROP_NOEXISTS_TABLE = -501,
- OLAP_ERR_ENGINE_LOAD_INDEX_TABLE_ERROR = -502,
- OLAP_ERR_TABLE_INSERT_DUPLICATION_ERROR = -503,
- OLAP_ERR_DELETE_VERSION_ERROR = -504,
- OLAP_ERR_GC_SCAN_PATH_ERROR = -505,
+ OLAP_ERR_ENGINE_INSERT_OLD_TABLET = -501,
Review comment:
Better to append the new code as -506 and not change the exist codes to keep compatiable, assume some log analysis tool may depends on these code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org