You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kelven Yang <ke...@citrix.com> on 2013/04/02 03:30:12 UTC

Review Request: Change StatsCollector to be of a normal CloudStack manager component to ensure proper initialization order

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10232/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

Change StatsCollector to be of a normal CloudStack manager component to ensure proper initialization order


This addresses bug CLOUDSTACK-1865.


Diffs
-----

  server/src/com/cloud/server/StatsCollector.java 4ae4999 

Diff: https://reviews.apache.org/r/10232/diff/


Testing
-------

Manual test to check its initialization order


Thanks,

Kelven Yang


Re: Review Request: Change StatsCollector to be of a normal CloudStack manager component to ensure proper initialization order

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10232/#review18612
-----------------------------------------------------------

Ship it!


Applied to 4.1:

commit 195a4ee5260a65b9de264dc0477c8da7aafd66a1
Author: Kelven Yang <ke...@gmail.com>
Date:   Mon Apr 1 18:25:06 2013 -0700

    CLOUDSTACK-1865: Change StatsCollector to be a manager so that it can initialize itself at proper run level

- Chip Childers


On April 2, 2013, 1:30 a.m., Kelven Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10232/
> -----------------------------------------------------------
> 
> (Updated April 2, 2013, 1:30 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Change StatsCollector to be of a normal CloudStack manager component to ensure proper initialization order
> 
> 
> This addresses bug CLOUDSTACK-1865.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/server/StatsCollector.java 4ae4999 
> 
> Diff: https://reviews.apache.org/r/10232/diff/
> 
> 
> Testing
> -------
> 
> Manual test to check its initialization order
> 
> 
> Thanks,
> 
> Kelven Yang
> 
>