You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:36:28 UTC
[GitHub] [incubator-apisix] ShiningRush opened a new issue #1200: Missing
global rules usage
ShiningRush opened a new issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200
Our team need a global plugin to enable CORS of service, then i found `global_rules`, but i didnt see any docs about it.
I think i could append its description to `doc/architecture-design.md`, and link `Global Rule` in homepage to it, do you agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis closed issue #1200: Missing global
rules usage
Posted by GitBox <gi...@apache.org>.
membphis closed issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1200: Missing
global rules usage
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200#issuecomment-594513102
You are right, PR welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] ShiningRush edited a comment on issue #1200:
Missing global rules usage
Posted by GitBox <gi...@apache.org>.
ShiningRush edited a comment on issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200#issuecomment-595732309
> @ShiningRush Apache APISIX not has the CROS plugin yet, welcome PR for CORS.
ok, i will do it after i append test case for the plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1200: Missing
global rules usage
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200#issuecomment-594970976
@ShiningRush Apache APISIX not has the CROS plugin yet, welcome PR for CORS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1200: Missing
global rules usage
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200#issuecomment-602306374
it is a bug of global rules, here is a related issue: https://github.com/apache/incubator-apisix/issues/1202
We are discussing how to fix this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] ShiningRush commented on issue #1200: Missing
global rules usage
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200#issuecomment-602247959
@moonming @membphis Why the global rules will not run header_filter and body filter? and there is no any notice or error raise when a plugin which using the one of them, it will cause user confused(such me, i have cost much time to debug why the cors plugin work well in unit tests but not in out project, because unit tests bind to plugin and the latter bind to global rule)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] ShiningRush commented on issue #1200: Missing
global rules usage
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #1200: Missing global rules usage
URL: https://github.com/apache/incubator-apisix/issues/1200#issuecomment-595732309
> @ShiningRush Apache APISIX not has the CROS plugin yet, welcome PR for CORS.
ok, i will do it after i append test case for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services