You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2009/09/28 04:05:17 UTC
[jira] Created: (SOLR-1470) index formats always compound
index formats always compound
-----------------------------
Key: SOLR-1470
URL: https://issues.apache.org/jira/browse/SOLR-1470
Project: Solr
Issue Type: Bug
Reporter: Yonik Seeley
Fix For: 1.4
Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1470) index formats always compound
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-1470.
-----------------------------------------
Resolution: Fixed
Assignee: Shalin Shekhar Mangar
Committed revision 819891.
Thanks Yonik and Mark!
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch, SOLR-1470.patch, SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1470) index formats always compound
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760564#action_12760564 ]
Mark Miller commented on SOLR-1470:
-----------------------------------
+1
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch, SOLR-1470.patch, SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1470) index formats always compound
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-1470:
----------------------------------------
Attachment: SOLR-1470.patch
# Sets useCompoundFile after setting merge policy
# Checks if merge policy is an instance of LogMergePolicy
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch, SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1470) index formats always compound
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-1470:
------------------------------
Attachment: SOLR-1470.patch
I think this will fix it
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1470) index formats always compound
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760139#action_12760139 ]
Mark Miller commented on SOLR-1470:
-----------------------------------
You know, it says that only works with LogMergePolicy (setUseCompoundFile) or it throws an exception. Thats another bug I think.
Should only set it that way if its that policy.
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1470) index formats always compound
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760561#action_12760561 ]
Shalin Shekhar Mangar commented on SOLR-1470:
---------------------------------------------
If there are no objections, shall I commit the latest patch?
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch, SOLR-1470.patch, SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1470) index formats always compound
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-1470:
----------------------------------------
Attachment: SOLR-1470.patch
setUseCompoundFile can only be invoked if the merge policy is an instance of LogMergePolicy. So if the policy is not LogMergePolicy, we can't call that setter regardless of the value of useCompoundFile. The previous patch is wrong because it will call setUseCompoundFile(false) even if policy is not LogMergePolicy.
I think throwing an exception would be wrong because that would mean the policy must always derive from LogMergePolicy. This patch logs a warning that if policy is not an instance of LogMergePolicy, the value of useCompoundFile is not used and the configured policy's defaults will take effect.
> index formats always compound
> -----------------------------
>
> Key: SOLR-1470
> URL: https://issues.apache.org/jira/browse/SOLR-1470
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1470.patch, SOLR-1470.patch, SOLR-1470.patch
>
>
> Seems like the index format is always compound now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.