[GitHub] [arrow] Christian8491 commented on a change in pull request #10855: ARROW-12946: [C++] String swap case kernel

[GitBox <gi...@apache.org>]

Christian8491 commented on a change in pull request #10855:
URL: https://github.com/apache/arrow/pull/10855#discussion_r681881936



##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -443,6 +488,17 @@ struct AsciiLower {
   }
 };
 
+void TransformAsciiSwapCase(const uint8_t* input, int64_t length, uint8_t* output) {
+  std::transform(input, input + length, output, ascii_swapcase);
+}
+
+template <typename Type>
+struct AsciiSwapCase {
+  static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
+    return StringDataTransform<Type>(ctx, batch, TransformAsciiSwapCase, out);
+  }
+};
+

Review comment:
       Addressed in [ba66c91](https://github.com/apache/arrow/pull/10855/commits/ba66c919e0f4e593fa0b70b193af79ea7ec76fa4)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org