You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/22 09:03:28 UTC
[GitHub] [arrow] thisisnic opened a new pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note [WIP]
thisisnic opened a new pull request #10774:
URL: https://github.com/apache/arrow/pull/10774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675695898
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +140,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
\`\`\`console
-$ ${contributors_command_line}
Review comment:
Ok, cool makes sense thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-978033325
Closing this ancient PR and starting again in a new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r678376985
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
Review comment:
Per Nic, It seems like the `arrow-datafusion` releases will not necessarily be in sync with the `arrow` and `arrow-rs` releases, so we should leave DataFusion out of this for now and revisit later as noted in the `TODO` comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675693007
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
Review comment:
Yep - I need to get in touch with the DF folks about their tagging conventions before I can do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-885815934
Thanks for doing this @thisisnic! Could you also please change how `n_commits` is calculated? It should iterate over `directories` and total up all the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-888667587
Created a follow-up ticket to port the release note generation to archery at some point: https://issues.apache.org/jira/browse/ARROW-13483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675703971
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
Review comment:
I've added a comment and opened up a ticket here to clarify with the DataFusion folks: https://github.com/apache/arrow-datafusion/issues/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic edited a comment on pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic edited a comment on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-885826595
> Thanks for doing this @thisisnic! Could you also please change how `n_commits` is calculated? It should iterate over `directories` and total up all the commits.
How do you mean, sorry, @ianmcook? I thought that's what it currently does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675692318
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
+git_ranges=(apache-arrow-${previous_version}..${git_tag} ${previous_version}..${version})
+
+committers=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -csn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
+ sort -rn
+)
+
+contributors=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -sn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
Review comment:
Good point, I will do this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675697595
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
+git_ranges=(apache-arrow-${previous_version}..${git_tag} ${previous_version}..${version})
+
+committers=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -csn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
Review comment:
Thank goodness for SO!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
thisisnic closed pull request #10774:
URL: https://github.com/apache/arrow/pull/10774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675782419
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +141,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
Review comment:
```suggestion
This release includes ${n_commits} commits from ${n_contributors} distinct contributors in ${#directories[@]} repositories.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675771356
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,38 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+# DataFusion directory and git ranges should be added here once git tagging convention confimed with DF team
Review comment:
Add a comment here to provide context:
```suggestion
# Previously this code counted commits, committers, and contributors only to the
# apache/arrow repository. After the Rust implementation of Arrow was moved to
# the separate apache/arrow-rs repository, this code was modified to also count
# commits, committers, and contributors to that repository.
#
# TODO: Add DataFusion directory and git ranges here once git tagging convention
# for apache/arrow-datafusion repo is confirmed with DF team
#
# TODO: Consider counting other apache/arrow-* repos here if tagging conventions
# permit (arrow-cookbook, arrow-site)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-888668476
Regenerated the release not for 5.0.0 with this patch: https://github.com/apache/arrow-site/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-888677047
> Regenerated the release note for 5.0.0 with this patch: [apache/arrow-site#131](https://github.com/apache/arrow-site/pull/131)
Thanks! @thisisnic there's a problem with the Rust committers; please see https://github.com/apache/arrow-site/pull/131/files#r678709259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675771356
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,38 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+# DataFusion directory and git ranges should be added here once git tagging convention confimed with DF team
Review comment:
Add a comment here to provide context:
```suggestion
# Previously this code counted commits, committers, and contributors only to the
# apache/arrow repository. After the Rust implementation of Arrow was moved to
# the separate apache/arrow-rs repository, this code was modified to also count
# commits, committers, and contributors to that repository.
#
# TODO: Add DataFusion directory and git ranges here once git tagging convention
# for apache/arrow-datafusion repo is confirmed with DF team
#
# TODO: Consider counting other apache/arrow-* repos here as tagging conventions
# permit (arrow-cookbook, arrow-site)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic removed a comment on pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic removed a comment on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-885826595
> Thanks for doing this @thisisnic! Could you also please change how `n_commits` is calculated? It should iterate over `directories` and total up all the commits.
How do you mean, sorry, @ianmcook? I thought that's what it currently does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675687111
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
Review comment:
Should this have the ARROW_DF_DIR in it as well?
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
+git_ranges=(apache-arrow-${previous_version}..${git_tag} ${previous_version}..${version})
+
+committers=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -csn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
+ sort -rn
+)
+
+contributors=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -sn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
Review comment:
Would it make sense to pull this `awk` command out into a variable so we only have to specify it once?
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +140,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
\`\`\`console
-$ ${contributors_command_line}
Review comment:
Do you know why `${contributors_command_line}` was called here but then `${contributors}` was used below? I tried to work out a reasoning why but couldn't quite grok what was going on here.
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
+git_ranges=(apache-arrow-${previous_version}..${git_tag} ${previous_version}..${version})
+
+committers=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -csn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
Review comment:
This is some `awk` right here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675695626
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
Review comment:
Ok cool, maybe a comment in here explaining that would be good to make it extra clear it's not an omission?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675692005
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +140,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
\`\`\`console
-$ ${contributors_command_line}
Review comment:
Originally there were two variables:
1. the code to run to get the list of commuters and number of commits
2. the output of running the code from 1
I think it was done like that before so that the variable 1 could be displayed in the output. However, now we use longer commands to generate the list of committers/commits, it's no longer desirable to display it and so this has been simplified by just using a single variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r678368561
##########
File path: dev/release/post-03-website.sh
##########
@@ -23,6 +23,8 @@ set -u
SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
ARROW_DIR="${SOURCE_DIR}/../.."
ARROW_SITE_DIR="${ARROW_DIR}/../arrow-site"
+ARROW_RS_DIR="${ARROW_DIR}/../arrow-rs"
+ARROW_DF_DIR="${ARROW_DIR}/../arrow-datafusion"
Review comment:
```suggestion
# TODO: add this back in when we have datafusion releases included
#ARROW_DF_DIR="${ARROW_DIR}/../arrow-datafusion"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-885848169
> Thanks for doing this @thisisnic! Could you also please change how `n_commits` is calculated? It should iterate over `directories` and total up all the commits.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675724815
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
+git_ranges=(apache-arrow-${previous_version}..${git_tag} ${previous_version}..${version})
+
+committers=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -csn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
+ sort -rn
+)
+
+contributors=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -sn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675692005
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +140,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
\`\`\`console
-$ ${contributors_command_line}
Review comment:
Originally there were two variables:
1. the actual code to run to get the list of committers and number of commits
2. the output of running the code from 1
I think it was done like that before so that the variable 1 could be displayed in the output. However, now we use longer commands to generate the list of committers/commits, it's no longer desirable to display it and so this has been simplified by just using a single variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675697595
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
+git_ranges=(apache-arrow-${previous_version}..${git_tag} ${previous_version}..${version})
+
+committers=$(
+ for (( i=0; i<${#directories[@]}; i++ ));
+ do
+ cd ${directories[$i]}
+ git shortlog -csn ${git_ranges[$i]}
+ done |
+ awk '{
+ name_email="";
+ for (i=2; i<=NF; i++) { name_email=name_email " " $i};
+ count_by_user[name_email]+=$1} END {for (name_email in count_by_user) print count_by_user[name_email], name_email}' |
Review comment:
Thank goodness for SO!
##########
File path: dev/release/post-03-website.sh
##########
@@ -55,14 +57,37 @@ rough_n_development_months=$((
git_tag=apache-arrow-${version}
git_range=apache-arrow-${previous_version}..${git_tag}
-committers_command_line="git shortlog -csn ${git_range}"
-contributors_command_line="git shortlog -sn ${git_range}"
-
-committers=$(${committers_command_line})
-contributors=$(${contributors_command_line})
+directories=("${ARROW_DIR}" "${ARROW_RS_DIR}")
Review comment:
Absolutely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-888707377
@thisisnic I manually fixed the problem with the Rust committers and applied the fix in https://github.com/apache/arrow-site/pull/133. So we're OK for the 5.0.0 release and there's no great urgency, but let's fix the problem before we merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-897590126
@ianmcook Do you remember what you did to get the correct list on this ticket? I've been looking into it but a lot of what I find online is people complaining that they can't find that information after a squash & merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-884760411
https://issues.apache.org/jira/browse/ARROW-12701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #10774: ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-888668476
Regenerated the release note for 5.0.0 with this patch: https://github.com/apache/arrow-site/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675775332
##########
File path: dev/release/post-03-website.sh
##########
@@ -128,7 +153,6 @@ cat <<ANNOUNCE >> "${announce_file}"
The following Apache committers merged contributed patches to the repository.
Review comment:
```suggestion
The following Apache committers merged contributed patches to Arrow repositories.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675692005
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +140,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
\`\`\`console
-$ ${contributors_command_line}
Review comment:
Originally there were two variables:
1. the actual code to run to get the list of commuters and number of commits
2. the output of running the code from 1
I think it was done like that before so that the variable 1 could be displayed in the output. However, now we use longer commands to generate the list of committers/commits, it's no longer desirable to display it and so this has been simplified by just using a single variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#issuecomment-885826595
> Thanks for doing this @thisisnic! Could you also please change how `n_commits` is calculated? It should iterate over `directories` and total up all the commits.
How do you mean, sorry? I thought that's what it currently does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10774: ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10774:
URL: https://github.com/apache/arrow/pull/10774#discussion_r675782419
##########
File path: dev/release/post-03-website.sh
##########
@@ -115,7 +141,6 @@ This is a major release covering more than ${rough_n_development_months} months
This release includes ${n_commits} commits from ${n_contributors} distinct contributors.
Review comment:
```suggestion
This release includes ${n_commits} commits from ${n_contributors} distinct contributors in ${#directories[@]} Arrow repositories.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org