You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/30 15:53:44 UTC
[GitHub] [airflow] robinedwards opened a new pull request #8017: Call
delete_dag on subdag without AttributeError
robinedwards opened a new pull request #8017: Call delete_dag on subdag without AttributeError
URL: https://github.com/apache/airflow/pull/8017
Deleting a subdag through the experimental api causes an `AttributeError` as a `DagRun` doesn't have a task_id column. DagRun's are handled prior to the subdag if statement so there is no need to remove them here. I also doubt we wanted to remove the parent dags DagRuns when removing a DagRun.
I have adapted the existing test class a bit to avoid repetition and added a case which exercises the above issue.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] robinedwards commented on issue #8017: Call delete_dag on
subdag without AttributeError
Posted by GitBox <gi...@apache.org>.
robinedwards commented on issue #8017: Call delete_dag on subdag without AttributeError
URL: https://github.com/apache/airflow/pull/8017#issuecomment-608060016
Woohoo thank you :-) Would it be possible to get this into 1.10.10?
On Thu, 2 Apr 2020, 19:48 Daniel Imberman, <no...@github.com> wrote:
> *@dimberman* approved this pull request.
>
> LGTM thank you @robinedwards <https://github.com/robinedwards> !
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/8017#pullrequestreview-386703325>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABHIYOVEKQWADBSVYPWQBLRKTMYPANCNFSM4LWWIHAQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dimberman commented on issue #8017: Call delete_dag on
subdag without AttributeError
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #8017: Call delete_dag on subdag without AttributeError
URL: https://github.com/apache/airflow/pull/8017#issuecomment-608067872
Should be, dont think we've done a code freeze yet :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dimberman merged pull request #8017: Call delete_dag on
subdag without AttributeError
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #8017: Call delete_dag on subdag without AttributeError
URL: https://github.com/apache/airflow/pull/8017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services