[GitHub] [druid] jihoonson commented on a change in pull request #11688: Task reports for parallel task: single phase and sequential mode

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #11688:
URL: https://github.com/apache/druid/pull/11688#discussion_r706565218



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -1415,4 +1432,169 @@ public Response getCompleteSubTaskSpecAttemptHistory(
       }
     }
   }
+
+  private RowIngestionMetersTotals getTotalsFromBuildSegmentsRowStats(Object buildSegmentsRowStats)
+  {
+    if (buildSegmentsRowStats instanceof RowIngestionMetersTotals) {
+      return (RowIngestionMetersTotals) buildSegmentsRowStats;
+    } else if (buildSegmentsRowStats instanceof Map) {

Review comment:
       Can you add some comment explaining when `buildSegmentsRowStats` can be a `Map` or `RowIngestionMetersTotals`?

##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -169,6 +173,11 @@
   @MonotonicNonNull
   private volatile TaskToolbox toolbox;
 
+  private IndexTask sequentialIndexTask;
+  private ParallelIndexTaskRunner<SinglePhaseSubTask, PushedSegmentsReport> parallelSinglePhaseRunner;

Review comment:
       I suppose you can get the current runner or task from `currentSubTaskHolder` and cast it properly depending on `isParallelMode()` instead of adding these?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org