[jira] Commented: (SOLR-142) RawResponseWriter - replace /admin/get-file.jsp

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492410 ] 

Hoss Man commented on SOLR-142:
-------------------------------

I still haven't looked at Ryan's latest patch on this issue (from Feb!) but if the only issue is that /admin/get-file.jsp has been deleted so links on the admin screen won't work because they assume the new handler, then maybe the best way to solve this is:

1) change the admin.jsp screen not to include links to either get-file.jsp or the new GetFile handler by default (a good idea since people might want to change the name of the handler) but if a gettableFiles section exists in the solrconfig, continue to link to get-files.jsp
2) document in the CHANGES recommending that people use the new GetFile handler and add links to it in an admin-extras.html file (since only they know which handler name they used)
3) makr get-files.jsp as heavily deprecated (so we can eventually get rid of it) and make it delegate to an anonymous on the fly created instance of the GetFile handler.


> RawResponseWriter - replace /admin/get-file.jsp
> -----------------------------------------------
>
>                 Key: SOLR-142
>                 URL: https://issues.apache.org/jira/browse/SOLR-142
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>            Reporter: Ryan McKinley
>            Priority: Trivial
>         Attachments: SOLR-142-RawResponseWriter.patch, SOLR-142-RawResponseWriter.patch, SOLR-142-RawResponseWriter.patch, SOLR-142-RawResponseWriter.patch, SOLR-142-RawResponseWriter.patch
>
>
> A RawResponseWriter writes a ContentStream directly to the response.
> This is useful to spit back a file directly from solr.  This implementation looks for a response property named "content" and sends it to the client.  If it can't find one, it delegates the response to another ResponseWriter.
> As an example, I added a GetAdminFileRequestHandler to replace /admin/get-file.jsp

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: Admin interface configuration changes?

[Chris Hostetter <ho...@fucit.org>]

: In looking into how to replace get-file.jsp and how to have an upload
: page for /update and /update/csv, I stumbled on the idea that we could
: have the list of options for what is displayed in the admin interface
: configured in solrconfig.xml.

blast from the past ... this is reminding me of a brainstorming session i
had with some CNET folks back before Solar became Apache Solar ... notes
from that meeting eventually made there way here...

	http://wiki.apache.org/solr/MakeSolrMoreSelfService

...in general, i think you're on the right track.  the one big adition i
would make is to ensure that external links are supported as well, and
that some arbitrary text can be included verbatim on the admin screen.

(and of course: if none of this info is in the <admin> block, we need the
old defaults still in index.jsp for backwards compatibility)



-Hoss

Admin interface configuration changes?

[Ryan McKinley <ry...@gmail.com>]

As we move to arbitrary path based configuration, the JSP admin pages 
don't really know where things are and what to link to.

In looking into how to replace get-file.jsp and how to have an upload 
page for /update and /update/csv, I stumbled on the idea that we could 
have the list of options for what is displayed in the admin interface 
configured in solrconfig.xml.

Perhaps something like:

<admin>
     <defaultQuery>solr</defaultQuery>
     <header>
       <links name="solr">
         <link name="Schema"   path="/admin/file?file=schema.xml" />
         <link name="Config"   path="/admin/file?file=solrconfig.xml" />
         <link name="Analysis" path="/admin/analysis.jsp" />
         <br/>
         <link name="Statistics"   path="/admin/stats.jsp" />
         <link name="Info"         path="/admin/registry.jsp" />
         <link name="Distribution" path="/admin/distributiondump.jsp" />
         <link name="Ping"         path="/admin/ping" />
         <link name="Logging"      path="/admin/logging.jsp" />
       </links>
       <links name="update">
         <link name="Update" path="/admin/?show=update.html" />
         <link name="CSV"    path="/admin/?show=updatecsv.html" />
       </links>
       <links name="App server">
         <link name="Properties"   path="/admin/properties" />
         <link name="Thread Dump"  path="/admin/threaddump.jsp" />
       </links>
     </header>
    ...

Thoughts?