[jira] [Commented] (FLINK-27449) The comment is lost when creating a Table from Datastream and Schema

["Shengkai Fang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529745#comment-17529745 ] 

Shengkai Fang commented on FLINK-27449:
---------------------------------------

Hi. Thanks for your report. I think it's a bug  when convert the datastream to table. In the SchemaTranslator#addPhysicalSourceDataTypeFields, it misses the comment part in the column.  

> The comment is lost when creating a Table from Datastream and Schema
> --------------------------------------------------------------------
>
>                 Key: FLINK-27449
>                 URL: https://issues.apache.org/jira/browse/FLINK-27449
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>    Affects Versions: 1.14.4
>            Reporter: Yuan Huang 
>            Priority: Major
>         Attachments: test_result.png
>
>
>  
> A user reported that the comment was lost when creating a Table from Datastream and Schema.
>  
> So this test will fail:
> {code:java}
> @Test
> public void test() {
>     StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
>     StreamTableEnvironment tableEnv = StreamTableEnvironment.create(env);
>     DataStream<String> dataStream = env.fromElements("Alice", "Bob", "John");
>     Schema.Builder builder = Schema.newBuilder();
>     builder.column("f0", DataTypes.of(String.class)).withComment("this is a comment");
>     Table table = tableEnv.fromDataStream(dataStream, builder.build()).as("user_name");
>     table.getResolvedSchema();
>     table.printSchema();
>     String expected = "(\n  `user_name` STRING COMMENT 'this is a comment'\n)";
>     Assert.assertEquals(expected, table.getResolvedSchema().toString());
> } {code}
>  
> !test_result.png|width=577,height=139!
> I checked that the built schema did contains the comment. However, the comment filed of resolved schema in the table is null.
> Is it a bug or just meets our expectations?
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)