You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/02 03:38:27 UTC
[GitHub] [solr] magibney opened a new pull request #588: SOLR-14764: FacetFieldProcessorByArray performance parity between `sort:"index asc"` and `sort:"index desc"`
magibney opened a new pull request #588:
URL: https://github.com/apache/solr/pull/588
See: [SOLR-14764](https://issues.apache.org/jira/browse/SOLR-14764)
Particularly for high-recall, high-cardinality cases, `sort:"index desc"` currently performs far less well than `sort:"index asc"` (passing every term through a priority queue as if it were a FIFO queue, but with lots of unnecessary comparisons).
This PR addresses that issue. Essentially: we can't really afford to ignore/abstract the fact that there is a direct connection between native ord sort order and order of iteration in building the priority queue for the `sort:"index [asc|desc]"` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #588: SOLR-14764: FacetFieldProcessorByArray performance parity between `sort:"index asc"` and `sort:"index desc"`
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #588:
URL: https://github.com/apache/solr/pull/588#issuecomment-1028141486
interesting! Honestly, I think my question really goes to the desire that we have as a community about having benchmarks in general, and doesn't have anything specific to this JIRA in retrospect. LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] magibney commented on pull request #588: SOLR-14764: FacetFieldProcessorByArray performance parity between `sort:"index asc"` and `sort:"index desc"`
Posted by GitBox <gi...@apache.org>.
magibney commented on pull request #588:
URL: https://github.com/apache/solr/pull/588#issuecomment-1028132267
On a naive/toy example (1,000,000 docs, terms facet on unique `id` field -- so, field cardinality of 1,000,000), core in tmpfs, comparing `q=*:*&rows=0&json.facet={blah:{type:terms,field:id,sort:"index desc"}}` against the same with `index asc`, current `main` branch lowest latency for asc is 20ms, for desc is 48ms.
With this optimization, both are down to 20ms (actually as low as 17ms, but that could just be noise).
It's super-simple to replicate the existing behavior on any current index: just find a field that's relatively high cardinality (1m+?) and facet on that, comparing `sort:"index asc"` with `sort:"index desc"`. I don't readily have access to "real" cores/collections that demonstrate current stock behavior (all the instances I manage have been running with a variant of this patch for well over a year).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #588: SOLR-14764: FacetFieldProcessorByArray performance parity between `sort:"index asc"` and `sort:"index desc"`
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #588:
URL: https://github.com/apache/solr/pull/588#issuecomment-1027830827
Is there anyway to have a performance (benchmark?) test that demonstrates the performance hit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org