[PATCH] HttpRequestAdapter returns wrong server port for a standanlone httpS connection

[Thorsten Ludewig <T....@FH-Wolfenbuettel.DE>]

Hi 

i've found a little bug (Tomcat 3.2.1) in the

  src/share/org/apache/tomcat/service/http/HttpRequestAdapter.java

file.


Bug Description:

  if you are running tomcat in standalone mode as user ,root'
  with JSSE (Java Secure Socket Extension) on port 443 you
  have URLs like:

    https://some.host/your/uri.html

  in this case ,request.getServerPort()' returns 80 and not 443


[PATCH]

  Method getServerPort() line 263... looks like
    else{
       serverPort=80;
    }


  changed to:

    else
    {
      if ( this.getScheme().equals( "https" ))
      {
        serverPort=443;
      }
      else
      {
        serverPort=80;
      }
    }
	


bye
- Thorsten

PS: I'm not subscribed to this mailing list so i don't read any
    reply on this mail to this list.
_____________________________________________________________________
  __________
 /___   ___/|
 |__/  /|__|/                                        Thorsten Ludewig
   /  / /  /|
  /__/ /  / /          Home Page: http://www.fh-wolfenbuettel.de/~th/
  |__|/  /_/____      E-Mail: Thorsten.Ludewig@RZ.FH-Wolfenbuettel.DE
     /_________/|                             Phone: +49 5331 939 488
     |_________|/                               FAX: +49 5331 939 482

RE: [PATCH] HttpRequestAdapter returns wrong server port for a standanlone httpS connection

[Marc Saegesser <ma...@apropos.com>]

This has already been fixed Tomcat 3.2.2.  The beta 2 release is available
for download at the URL below.

http://jakarta.apache.org/site/binindex.html

> -----Original Message-----
> From: Thorsten.Ludewig@FH-Wolfenbuettel.DE
> [mailto:Thorsten.Ludewig@FH-Wolfenbuettel.DE]On Behalf Of Thorsten
> Ludewig
> Sent: Wednesday, March 28, 2001 4:12 AM
> To: tomcat-dev@jakarta.apache.org
> Subject: [PATCH] HttpRequestAdapter returns wrong server port for a
> standanlone httpS connection
>
>
> Hi
>
> i've found a little bug (Tomcat 3.2.1) in the
>
>   src/share/org/apache/tomcat/service/http/HttpRequestAdapter.java
>
> file.
>
>
> Bug Description:
>
>   if you are running tomcat in standalone mode as user ,root'
>   with JSSE (Java Secure Socket Extension) on port 443 you
>   have URLs like:
>
>     https://some.host/your/uri.html
>
>   in this case ,request.getServerPort()' returns 80 and not 443
>
>
> [PATCH]
>
>   Method getServerPort() line 263... looks like
>     else{
>        serverPort=80;
>     }
>
>
>   changed to:
>
>     else
>     {
>       if ( this.getScheme().equals( "https" ))
>       {
>         serverPort=443;
>       }
>       else
>       {
>         serverPort=80;
>       }
>     }
>
>
>
> bye
> - Thorsten
>
> PS: I'm not subscribed to this mailing list so i don't read any
>     reply on this mail to this list.
> _____________________________________________________________________
>   __________
>  /___   ___/|
>  |__/  /|__|/                                        Thorsten Ludewig
>    /  / /  /|
>   /__/ /  / /          Home Page: http://www.fh-wolfenbuettel.de/~th/
>   |__|/  /_/____      E-Mail: Thorsten.Ludewig@RZ.FH-Wolfenbuettel.DE
>      /_________/|                             Phone: +49 5331 939 488
>      |_________|/                               FAX: +49 5331 939 482