You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/06/08 16:56:25 UTC

[1/2] commons-io git commit: Add slots for case sensitivity and case preservation.

Repository: commons-io
Updated Branches:
  refs/heads/master 0cbb22ddd -> e5f5eac9e


Add slots for case sensitivity and case preservation.

Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/ef0fb794
Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/ef0fb794
Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/ef0fb794

Branch: refs/heads/master
Commit: ef0fb794d49e9184913581f561c87ba8c62d5e4e
Parents: 9e801d9
Author: Gary Gregory <ga...@gmail.com>
Authored: Fri Jun 8 10:55:52 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Fri Jun 8 10:55:52 2018 -0600

----------------------------------------------------------------------
 .../java/org/apache/commons/io/FileSystem.java  | 86 ++++++++++++++------
 1 file changed, 62 insertions(+), 24 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-io/blob/ef0fb794/src/main/java/org/apache/commons/io/FileSystem.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/io/FileSystem.java b/src/main/java/org/apache/commons/io/FileSystem.java
index d6f50ad..c3ec260 100644
--- a/src/main/java/org/apache/commons/io/FileSystem.java
+++ b/src/main/java/org/apache/commons/io/FileSystem.java
@@ -33,9 +33,15 @@ import java.util.Objects;
  */
 public enum FileSystem {
 
-    GENERIC(Integer.MAX_VALUE, Integer.MAX_VALUE, new char[] { 0 }, new String[] {}),
+    /**
+     * Generic file system.
+     */
+    GENERIC(false, false, Integer.MAX_VALUE, Integer.MAX_VALUE, new char[] { 0 }, new String[] {}),
 
-    LINUX(255, 4096, new char[] {
+    /**
+     * Linux file system.
+     */
+    LINUX(true, true, 255, 4096, new char[] {
             // KEEP THIS ARRAY SORTED!
             // @formatter:off
             // ASCII NUL
@@ -44,7 +50,10 @@ public enum FileSystem {
             // @formatter:on
     }, new String[] {}),
 
-    MAC_OSX(255, 1024, new char[] {
+    /**
+     * MacOS file system.
+     */
+    MAC_OSX(true, true, 255, 1024, new char[] {
             // KEEP THIS ARRAY SORTED!
             // @formatter:off
             // ASCII NUL
@@ -54,18 +63,21 @@ public enum FileSystem {
             // @formatter:on
     }, new String[] {}),
 
-    WINDOWS(255, 32000, new char[] {
-            // KEEP THIS ARRAY SORTED!
-            // @formatter:off
-            // ASCII NUL
-            0,
-            // 1-31 may be allowed in file streams
-            1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28,
-            29, 30, 31,
-            '"', '*', '/', ':', '<', '>', '?', '\\', '|'
-            // @formatter:on
-    },
-            // KEEP THIS ARRAY SORTED!
+    /**
+     * Windows file system.
+     */
+    WINDOWS(false, true, 255,
+            32000, new char[] {
+                    // KEEP THIS ARRAY SORTED!
+                    // @formatter:off
+                    // ASCII NUL
+                    0,
+                    // 1-31 may be allowed in file streams
+                    1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28,
+                    29, 30, 31,
+                    '"', '*', '/', ':', '<', '>', '?', '\\', '|'
+                    // @formatter:on
+            }, // KEEP THIS ARRAY SORTED!
             new String[] { "AUX", "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9", "CON", "LPT1",
                     "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9", "NUL", "PRN" });
 
@@ -178,6 +190,8 @@ public enum FileSystem {
         return osName.toUpperCase(Locale.ROOT).startsWith(osNamePrefix.toUpperCase(Locale.ROOT));
     }
 
+    private final boolean casePreserving;
+    private final boolean caseSensitive;
     private final char[] illegalFileNameChars;
     private final int maxFileNameLength;
     private final int maxPathLength;
@@ -186,21 +200,27 @@ public enum FileSystem {
     /**
      * Constructs a new instance.
      * 
+     * @param caseSensitive
+     *            Whether this file system is case sensitive.
+     * @param casePreserving
+     *            Whether this file system is case preserving.
      * @param maxFileLength
-     *            the maximum length for file names. The file name does not include folders.
+     *            The maximum length for file names. The file name does not include folders.
      * @param maxPathLength
-     *            the maximum length of the path to a file. This can include folders.
+     *            The maximum length of the path to a file. This can include folders.
      * @param illegalFileNameChars
-     *            illegal characters for this file system.
+     *            Illegal characters for this file system.
      * @param reservedFileNames
-     *            the reserved file names.
+     *            The reserved file names.
      */
-    FileSystem(final int maxFileLength, final int maxPathLength, final char[] illegalFileNameChars,
-               final String[] reservedFileNames) {
+    FileSystem(final boolean caseSensitive, final boolean casePreserving, final int maxFileLength,
+               final int maxPathLength, final char[] illegalFileNameChars, final String[] reservedFileNames) {
         this.maxFileNameLength = maxFileLength;
         this.maxPathLength = maxPathLength;
         this.illegalFileNameChars = Objects.requireNonNull(illegalFileNameChars, "illegalFileNameChars");
         this.reservedFileNames = Objects.requireNonNull(reservedFileNames, "reservedFileNames");
+        this.caseSensitive = caseSensitive;
+        this.casePreserving = casePreserving;
     }
 
     /**
@@ -232,7 +252,7 @@ public enum FileSystem {
 
     /**
      * Gets a cloned copy of the reserved file names.
-     * 
+     *
      * @return the reserved file names.
      */
     public String[] getReservedFileNames() {
@@ -240,8 +260,26 @@ public enum FileSystem {
     }
 
     /**
-     * Returns {@code true} if the given character is illegal in a file name, {@code false} otherwise.
+     * Whether this file system preserves case.
+     * 
+     * @return Whether this file system preserves case.
+     */
+    public boolean isCasePreserving() {
+        return casePreserving;
+    }
+
+    /**
+     * Whether this file system is case-sensitive.
      * 
+     * @return Whether this file system is case-sensitive.
+     */
+    public boolean isCaseSensitive() {
+        return caseSensitive;
+    }
+
+    /**
+     * Returns {@code true} if the given character is illegal in a file name, {@code false} otherwise.
+     *
      * @param c
      *            the character to test
      * @return {@code true} if the given character is illegal in a file name, {@code false} otherwise.
@@ -276,7 +314,7 @@ public enum FileSystem {
 
     /**
      * Returns whether the given string is a reserved file name.
-     * 
+     *
      * @param candidate
      *            the string to test
      * @return {@code true} if the given string is a reserved file name.


[2/2] commons-io git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-io

Posted by gg...@apache.org.
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-io

Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/e5f5eac9
Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/e5f5eac9
Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/e5f5eac9

Branch: refs/heads/master
Commit: e5f5eac9e65620e4697b922e0f49b7bbdb90695e
Parents: ef0fb79 0cbb22d
Author: Gary Gregory <ga...@gmail.com>
Authored: Fri Jun 8 10:56:11 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Fri Jun 8 10:56:11 2018 -0600

----------------------------------------------------------------------
 .../commons/io/FileSystemUtilsTestCase.java     | 40 ++++++++++++++++++++
 1 file changed, 40 insertions(+)
----------------------------------------------------------------------