You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/12 14:29:44 UTC

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12016: [testclient] Add new option --num-messages for consumer and reader

gaoran10 commented on a change in pull request #12016:
URL: https://github.com/apache/pulsar/pull/12016#discussion_r706846391



##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -293,6 +297,11 @@ public static void main(String[] args) throws Exception {
                     PerfClientUtils.exit(0);
                 }
             }
+            if (arguments.numMessages > 0 && totalMessagesReceived.sum() >= arguments.numMessages) {
+                log.info("------------------- DONE -----------------------");

Review comment:
       Could we add a hint that why the perf tool is done? 
   
   Such as `log.inf("------------------- DONE (reach consume message num in total) -----------------------")




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org