[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11884: use invocation return support

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #11884:
URL: https://github.com/apache/dubbo/pull/11884#discussion_r1147047323


##########
dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java:
##########
@@ -150,7 +164,15 @@ public void decode() throws Exception {
 
     private void handleValue(ObjectInput in) throws IOException {
         try {
-            Type[] returnTypes = RpcUtils.getReturnTypes(invocation);
+            Type[] returnTypes = null;
+            if(useInvocationReturn) {
+                if(invocation instanceof RpcInvocation) {
+                    returnTypes = ((RpcInvocation) invocation).getReturnTypes();
+                }
+            }

Review Comment:
   When calling generically, the deserialization here should be implemented by GenericFilter. If there is a generic problem, PojoUtils should be modified to solve it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org