You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/02/12 10:26:46 UTC
Review Request 30921: Add test in falcon to test feed SLA feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30921/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1021
https://issues.apache.org/jira/browse/FALCON-1021
Repository: falcon-git
Description
-------
A test needs to be added to test SLA for feeds corresponding to FALCON-721
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java cec7684
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java PRE-CREATION
Diff: https://reviews.apache.org/r/30921/diff/
Testing
-------
Done.
Thanks,
PRAGYA MITTAL
Re: Review Request 30921: Add test in falcon to test feed SLA feature
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30921/#review72447
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Feb. 12, 2015, 11:23 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30921/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 11:23 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1021
> https://issues.apache.org/jira/browse/FALCON-1021
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added to test SLA for feeds corresponding to FALCON-721
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java cec7684
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30921/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30921: Add test in falcon to test feed SLA feature
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30921/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 7:23 a.m.)
Review request for Falcon.
Bugs: FALCON-1021
https://issues.apache.org/jira/browse/FALCON-1021
Repository: falcon-git
Description
-------
A test needs to be added to test SLA for feeds corresponding to FALCON-721
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java cec7684
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java PRE-CREATION
Diff: https://reviews.apache.org/r/30921/diff/
Testing
-------
Done.
Thanks,
PRAGYA MITTAL
Re: Review Request 30921: Add test in falcon to test feed SLA feature
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Feb. 12, 2015, 11:13 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java, line 68
> > <https://reviews.apache.org/r/30921/diff/1/?file=861653#file861653line68>
> >
> > why are we setting acl explicitly ? My understanding of this is that it should already have good values at this point.
> >
> > We tinker with acls only for authentication/authorization related tests.
Added it as an extra check. But i think it is handled by regression now. Will remove this in the new patch.
> On Feb. 12, 2015, 11:13 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java, line 127
> > <https://reviews.apache.org/r/30921/diff/1/?file=861653#file861653line127>
> >
> > Can you print expected and actual response as part of your assertion message ?
Added validate function to handle the same.
> On Feb. 12, 2015, 11:13 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java, line 152
> > <https://reviews.apache.org/r/30921/diff/1/?file=861653#file861653line152>
> >
> > Can you print expected and actual response as part of your assertion message ?
Added validate function to handle the same.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30921/#review72260
-----------------------------------------------------------
On Feb. 12, 2015, 9:26 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30921/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 9:26 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1021
> https://issues.apache.org/jira/browse/FALCON-1021
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added to test SLA for feeds corresponding to FALCON-721
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java cec7684
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30921/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30921: Add test in falcon to test feed SLA feature
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30921/#review72260
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
<https://reviews.apache.org/r/30921/#comment118330>
Please import individual classes that are needed by your test. Mass import is not ok.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
<https://reviews.apache.org/r/30921/#comment118334>
why are we setting acl explicitly ? My understanding of this is that it should already have good values at this point.
We tinker with acls only for authentication/authorization related tests.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
<https://reviews.apache.org/r/30921/#comment118336>
Can you print expected and actual response as part of your assertion message ?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
<https://reviews.apache.org/r/30921/#comment118337>
Can you print expected and actual response as part of your assertion message ?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
<https://reviews.apache.org/r/30921/#comment118340>
same as above
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java
<https://reviews.apache.org/r/30921/#comment118342>
same as above
- Raghav Gautam
On Feb. 12, 2015, 1:26 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30921/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 1:26 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1021
> https://issues.apache.org/jira/browse/FALCON-1021
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added to test SLA for feeds corresponding to FALCON-721
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java cec7684
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30921/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>