You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/02 11:49:27 UTC

[GitHub] [rocketmq] duhenglucky opened a new pull request #1911: Polish the commited offset logic

duhenglucky opened a new pull request #1911: Polish the commited offset logic
URL: https://github.com/apache/rocketmq/pull/1911
 
 
   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] ShannonDing merged pull request #1911: [ISSUE #1912]Polish the commited offset logic

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #1911: [ISSUE #1912]Polish the commited offset logic
URL: https://github.com/apache/rocketmq/pull/1911
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls commented on issue #1911: [ISSUE #1912]Polish the commited offset logic

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1911: [ISSUE #1912]Polish the commited offset logic
URL: https://github.com/apache/rocketmq/pull/1911#issuecomment-607816788
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29794727/badge)](https://coveralls.io/builds/29794727)
   
   Coverage decreased (-0.08%) to 50.833% when pulling **90f120b685dd4d4b81d4c7d40c540dc69d455f37 on duhenglucky:pull_namespace_fix** into **0a9822e5f4667654b37bd480865174d1bb2c28fe on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] codecov-io commented on issue #1911: [ISSUE #1912]Polish the commited offset logic

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1911: [ISSUE #1912]Polish the commited offset logic
URL: https://github.com/apache/rocketmq/pull/1911#issuecomment-607817215
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1911?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`develop@1558e05`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/1911/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/1911?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##             develop    #1911   +/-   ##
   ==========================================
     Coverage           ?   45.06%           
     Complexity         ?     4190           
   ==========================================
     Files              ?      544           
     Lines              ?    35722           
     Branches           ?     4743           
   ==========================================
     Hits               ?    16099           
     Misses             ?    17581           
     Partials           ?     2042           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1911?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1911?src=pr&el=footer). Last update [1558e05...90f120b](https://codecov.io/gh/apache/rocketmq/pull/1911?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services