[GitHub] [arrow] jorisvandenbossche commented on pull request #34883: GH-34882: [Python] Binding for FixedShapeTensorType

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on PR #34883:
URL: https://github.com/apache/arrow/pull/34883#issuecomment-1502846716

   On the topic of taking the permutation into account or not, I personally don't have a strong opinion what to do by default, but to list the different options:
   
   1. Return always the permuted array (so non C-contiguous is permutation is non-trivial)
   2. Provide option to indicate if you want the permuted result or not (e.g. `permuted=True/False`)
     a) with returning permuted array as default
     b) with returning the actual C-contiguous array by default 
   3. Return always the actual C-contiguous array and raise error if permutation is non-trivial
   4. Return always the actual C-contiguous array and just ignore permutation info (and clearly document this, leave it to the user to permute if they want)
   
   One question is: are there good use cases for _not_ wanting the automatic permutation? Because if so, always returning the permuted array (option 1) is also annoying because then it's less trivial to go back to the plain C array, instead of permuting the C array? 
   Personally I don't like option 3, because that restricts the user to actually get the ndarray, even if they are fine with ignoring any permutation info.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org