You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mitre88 (via GitHub)" <gi...@apache.org> on 2026/07/31 22:16:16 UTC

Re: [PR] Keep Campaign Manager delete report provision check in __init__ [airflow]

mitre88 commented on PR #70530:
URL: https://github.com/apache/airflow/pull/70530#issuecomment-5147925486

   Reworked per the #70296 rule — thanks for the detailed write-up, @potiuk.
   
   The guard is a pure provision check (exactly-one-of `report_name`/`report_id`), so it now stays in `__init__`, rewritten in place with `is not None` polarity via `exactly_one(...)`, raising `ValueError`. Nothing moved to `execute()` (rendered-`None` already no-ops safely there — no delete call is made). Tests updated to assert failure at construction time. The `validate-operators-init` hook passes locally on the file and the exemption entry is removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org