You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2022/11/02 02:07:39 UTC
[shardingsphere] branch master updated: Code refactor and cleanup (#21898)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 377e1c12821 Code refactor and cleanup (#21898)
377e1c12821 is described below
commit 377e1c12821b112589a7ed762f5ba5ad4e918748
Author: 吴伟杰 <wu...@apache.org>
AuthorDate: Wed Nov 2 10:07:32 2022 +0800
Code refactor and cleanup (#21898)
---
.../ReplayRequiredSessionVariablesLoader.java | 3 +
.../admin/mysql/executor/KillProcessExecutor.java | 6 +-
.../mysql/executor/ShowConnectionIdExecutor.java | 8 +--
.../mysql/executor/ShowTransactionExecutor.java | 2 +-
.../admin/mysql/executor/ShowVersionExecutor.java | 2 +-
.../executor/UnicastResourceShowExecutor.java | 2 +-
.../PostgreSQLSessionVariableHandlerFactory.java | 3 +
.../common/constant/DistSQLScriptConstants.java | 4 +-
.../rql/rule/SingleTableRulesQueryResultSet.java | 5 +-
.../command/MySQLCommandPacketFactoryTest.java | 67 +++++++++++-----------
...ddShardingHintDatabaseValueStatementAssert.java | 2 +-
11 files changed, 52 insertions(+), 52 deletions(-)
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/executor/ReplayRequiredSessionVariablesLoader.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/executor/ReplayRequiredSessionVariablesLoader.java
index 26abae61ec7..3106c1d586f 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/executor/ReplayRequiredSessionVariablesLoader.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/executor/ReplayRequiredSessionVariablesLoader.java
@@ -17,6 +17,8 @@
package org.apache.shardingsphere.proxy.backend.handler.admin.executor;
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
import org.apache.shardingsphere.infra.util.spi.ShardingSphereServiceLoader;
import org.apache.shardingsphere.infra.util.spi.type.typed.TypedSPIRegistry;
@@ -26,6 +28,7 @@ import java.util.Collections;
/**
* Loader for session variables need to be replayed.
*/
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class ReplayRequiredSessionVariablesLoader {
static {
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/KillProcessExecutor.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/KillProcessExecutor.java
index 90c032d04eb..8047518b586 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/KillProcessExecutor.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/KillProcessExecutor.java
@@ -17,6 +17,7 @@
package org.apache.shardingsphere.proxy.backend.handler.admin.mysql.executor;
+import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.mode.process.event.KillProcessListIdRequestEvent;
import org.apache.shardingsphere.proxy.backend.context.ProxyContext;
import org.apache.shardingsphere.proxy.backend.handler.admin.executor.DatabaseAdminExecutor;
@@ -26,14 +27,11 @@ import org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dal.MySQ
/**
* Kill process executor.
*/
+@RequiredArgsConstructor
public final class KillProcessExecutor implements DatabaseAdminExecutor {
private final MySQLKillStatement killStatement;
- public KillProcessExecutor(final MySQLKillStatement sqlStatement) {
- this.killStatement = sqlStatement;
- }
-
/**
* Execute.
*
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowConnectionIdExecutor.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowConnectionIdExecutor.java
index 6f2738c9c4e..fb21e3700a1 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowConnectionIdExecutor.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowConnectionIdExecutor.java
@@ -18,6 +18,7 @@
package org.apache.shardingsphere.proxy.backend.handler.admin.mysql.executor;
import lombok.Getter;
+import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.executor.sql.execute.result.query.QueryResultMetaData;
import org.apache.shardingsphere.infra.executor.sql.execute.result.query.impl.raw.metadata.RawQueryResultColumnMetaData;
import org.apache.shardingsphere.infra.executor.sql.execute.result.query.impl.raw.metadata.RawQueryResultMetaData;
@@ -37,19 +38,16 @@ import java.util.Collections;
/**
* Show connection id executor.
*/
+@RequiredArgsConstructor
@Getter
public final class ShowConnectionIdExecutor implements DatabaseAdminQueryExecutor {
public static final String FUNCTION_NAME = "connection_id()";
- private SelectStatement sqlStatement;
+ private final SelectStatement sqlStatement;
private MergedResult mergedResult;
- public ShowConnectionIdExecutor(final SelectStatement sqlStatement) {
- this.sqlStatement = sqlStatement;
- }
-
@Override
public void execute(final ConnectionSession connectionSession) {
mergedResult = new LocalDataMergedResult(Collections.singleton(new LocalDataQueryResultRow(connectionSession.getConnectionId())));
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowTransactionExecutor.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowTransactionExecutor.java
index fcf71443afa..130398279c9 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowTransactionExecutor.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowTransactionExecutor.java
@@ -34,8 +34,8 @@ import java.util.Collections;
/**
* Show transaction executor.
*/
-@Getter
@RequiredArgsConstructor
+@Getter
public final class ShowTransactionExecutor implements DatabaseAdminQueryExecutor {
public static final String TRANSACTION_READ_ONLY = "@@session.transaction_read_only";
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowVersionExecutor.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowVersionExecutor.java
index 072ea7c12bf..615785ea133 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowVersionExecutor.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/ShowVersionExecutor.java
@@ -37,8 +37,8 @@ import java.util.Collections;
/**
* Show version executor.
*/
-@Getter
@RequiredArgsConstructor
+@Getter
public final class ShowVersionExecutor implements DatabaseAdminQueryExecutor {
public static final String FUNCTION_NAME = "version()";
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/UnicastResourceShowExecutor.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/UnicastResourceShowExecutor.java
index 4fc050bd34b..f392a59e0bf 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/UnicastResourceShowExecutor.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/mysql/executor/UnicastResourceShowExecutor.java
@@ -54,8 +54,8 @@ import java.util.stream.Collectors;
/**
* Unicast resource show executor.
*/
-@Getter
@RequiredArgsConstructor
+@Getter
public final class UnicastResourceShowExecutor implements DatabaseAdminQueryExecutor {
private final DatabaseCommunicationEngineFactory databaseCommunicationEngineFactory = DatabaseCommunicationEngineFactory.getInstance();
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/PostgreSQLSessionVariableHandlerFactory.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/PostgreSQLSessionVariableHandlerFactory.java
index 9d1ca0639fc..3ef4bd8996d 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/PostgreSQLSessionVariableHandlerFactory.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/PostgreSQLSessionVariableHandlerFactory.java
@@ -17,12 +17,15 @@
package org.apache.shardingsphere.proxy.backend.handler.admin.postgresql;
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
import org.apache.shardingsphere.infra.util.spi.ShardingSphereServiceLoader;
import org.apache.shardingsphere.infra.util.spi.type.typed.TypedSPIRegistry;
/**
* Factory for {@link PostgreSQLSessionVariableHandler}.
*/
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class PostgreSQLSessionVariableHandlerFactory {
static {
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/common/constant/DistSQLScriptConstants.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/common/constant/DistSQLScriptConstants.java
index 934ea6a3368..5acfcbff263 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/common/constant/DistSQLScriptConstants.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/common/constant/DistSQLScriptConstants.java
@@ -178,9 +178,9 @@ public final class DistSQLScriptConstants {
public static final String CIPHER = "CIPHER=%s";
- public static final String TYPE = "TYPE(NAME=\'%s\', PROPERTIES(%s))";
+ public static final String TYPE = "TYPE(NAME='%s', PROPERTIES(%s))";
- public static final String ENCRYPT_TYPE_WITHOUT_PROPERTIES = "TYPE(NAME=\'%s\')";
+ public static final String ENCRYPT_TYPE_WITHOUT_PROPERTIES = "TYPE(NAME='%s')";
public static final String CREATE_SHADOW = "CREATE SHADOW RULE";
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rql/rule/SingleTableRulesQueryResultSet.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rql/rule/SingleTableRulesQueryResultSet.java
index 09240c8b643..51a97581498 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rql/rule/SingleTableRulesQueryResultSet.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rql/rule/SingleTableRulesQueryResultSet.java
@@ -23,7 +23,6 @@ import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
import org.apache.shardingsphere.singletable.rule.SingleTableRule;
import org.apache.shardingsphere.sql.parser.sql.common.statement.SQLStatement;
-import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
@@ -43,7 +42,7 @@ public final class SingleTableRulesQueryResultSet implements DatabaseDistSQLResu
@Override
public Collection<String> getColumnNames() {
- return Arrays.asList("storage_unit_name");
+ return Collections.singletonList("storage_unit_name");
}
@Override
@@ -53,7 +52,7 @@ public final class SingleTableRulesQueryResultSet implements DatabaseDistSQLResu
@Override
public Collection<Object> getRowData() {
- return Arrays.asList(data.next());
+ return Collections.singletonList(data.next());
}
@Override
diff --git a/proxy/frontend/mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/MySQLCommandPacketFactoryTest.java b/proxy/frontend/mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/MySQLCommandPacketFactoryTest.java
index f66ce65181d..27853a661fe 100644
--- a/proxy/frontend/mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/MySQLCommandPacketFactoryTest.java
+++ b/proxy/frontend/mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/MySQLCommandPacketFactoryTest.java
@@ -44,8 +44,6 @@ import org.mockito.Answers;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
-import java.sql.SQLException;
-
import static org.hamcrest.CoreMatchers.instanceOf;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.mockito.ArgumentMatchers.anyInt;
@@ -62,33 +60,34 @@ public final class MySQLCommandPacketFactoryTest {
private ConnectionSession connectionSession;
@Test
- public void assertNewInstanceWithComQuitPacket() throws SQLException {
+ public void assertNewInstanceWithComQuitPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_QUIT, payload, connectionSession), instanceOf(MySQLComQuitPacket.class));
}
@Test
- public void assertNewInstanceWithComInitDbPacket() throws SQLException {
+ public void assertNewInstanceWithComInitDbPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_INIT_DB, payload, connectionSession), instanceOf(MySQLComInitDbPacket.class));
}
@Test
- public void assertNewInstanceWithComFieldListPacket() throws SQLException {
+ public void assertNewInstanceWithComFieldListPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_FIELD_LIST, payload, connectionSession), instanceOf(MySQLComFieldListPacket.class));
}
@Test
- public void assertNewInstanceWithComQueryPacket() throws SQLException {
+ public void assertNewInstanceWithComQueryPacket() {
when(payload.readStringEOF()).thenReturn("SHOW TABLES");
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_QUERY, payload, connectionSession), instanceOf(MySQLComQueryPacket.class));
}
@Test
- public void assertNewInstanceWithComStmtPreparePacket() throws SQLException {
+ public void assertNewInstanceWithComStmtPreparePacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_STMT_PREPARE, payload, connectionSession), instanceOf(MySQLComStmtPreparePacket.class));
}
+ @SuppressWarnings("unchecked")
@Test
- public void assertNewInstanceWithComStmtExecutePacket() throws SQLException {
+ public void assertNewInstanceWithComStmtExecutePacket() {
when(payload.readInt1()).thenReturn(MySQLNewParametersBoundFlag.PARAMETER_TYPE_EXIST.getValue());
when(payload.readInt4()).thenReturn(1);
when(payload.getByteBuf().getIntLE(anyInt())).thenReturn(1);
@@ -101,132 +100,132 @@ public final class MySQLCommandPacketFactoryTest {
}
@Test
- public void assertNewInstanceWithComStmtClosePacket() throws SQLException {
+ public void assertNewInstanceWithComStmtClosePacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_STMT_CLOSE, payload, connectionSession), instanceOf(MySQLComStmtClosePacket.class));
}
@Test
- public void assertNewInstanceWithComPingPacket() throws SQLException {
+ public void assertNewInstanceWithComPingPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_PING, payload, connectionSession), instanceOf(MySQLComPingPacket.class));
}
@Test
- public void assertNewInstanceWithComSleepPacket() throws SQLException {
+ public void assertNewInstanceWithComSleepPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_SLEEP, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComCreateDbPacket() throws SQLException {
+ public void assertNewInstanceWithComCreateDbPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_CREATE_DB, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComDropDbPacket() throws SQLException {
+ public void assertNewInstanceWithComDropDbPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_DROP_DB, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComRefreshPacket() throws SQLException {
+ public void assertNewInstanceWithComRefreshPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_REFRESH, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComShutDownPacket() throws SQLException {
+ public void assertNewInstanceWithComShutDownPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_SHUTDOWN, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComStatisticsPacket() throws SQLException {
+ public void assertNewInstanceWithComStatisticsPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_STATISTICS, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComProcessInfoPacket() throws SQLException {
+ public void assertNewInstanceWithComProcessInfoPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_PROCESS_INFO, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComConnectPacket() throws SQLException {
+ public void assertNewInstanceWithComConnectPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_CONNECT, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComProcessKillPacket() throws SQLException {
+ public void assertNewInstanceWithComProcessKillPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_PROCESS_KILL, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComDebugPacket() throws SQLException {
+ public void assertNewInstanceWithComDebugPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_DEBUG, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComTimePacket() throws SQLException {
+ public void assertNewInstanceWithComTimePacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_TIME, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComDelayedInsertPacket() throws SQLException {
+ public void assertNewInstanceWithComDelayedInsertPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_DELAYED_INSERT, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComChangeUserPacket() throws SQLException {
+ public void assertNewInstanceWithComChangeUserPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_CHANGE_USER, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComBinlogDumpPacket() throws SQLException {
+ public void assertNewInstanceWithComBinlogDumpPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_BINLOG_DUMP, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComTableDumpPacket() throws SQLException {
+ public void assertNewInstanceWithComTableDumpPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_TABLE_DUMP, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComConnectOutPacket() throws SQLException {
+ public void assertNewInstanceWithComConnectOutPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_CONNECT_OUT, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComRegisterSlavePacket() throws SQLException {
+ public void assertNewInstanceWithComRegisterSlavePacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_REGISTER_SLAVE, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComStmtSendLongDataPacket() throws SQLException {
+ public void assertNewInstanceWithComStmtSendLongDataPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_STMT_SEND_LONG_DATA, payload, connectionSession), instanceOf(MySQLComStmtSendLongDataPacket.class));
}
@Test
- public void assertNewInstanceWithComStmtResetPacket() throws SQLException {
+ public void assertNewInstanceWithComStmtResetPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_STMT_RESET, payload, connectionSession), instanceOf(MySQLComStmtResetPacket.class));
}
@Test
- public void assertNewInstanceWithComSetOptionPacket() throws SQLException {
+ public void assertNewInstanceWithComSetOptionPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_SET_OPTION, payload, connectionSession), instanceOf(MySQLComSetOptionPacket.class));
}
@Test
- public void assertNewInstanceWithComStmtFetchPacket() throws SQLException {
+ public void assertNewInstanceWithComStmtFetchPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_STMT_FETCH, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComDaemonPacket() throws SQLException {
+ public void assertNewInstanceWithComDaemonPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_DAEMON, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComBinlogDumpGTIDPacket() throws SQLException {
+ public void assertNewInstanceWithComBinlogDumpGTIDPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_BINLOG_DUMP_GTID, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
@Test
- public void assertNewInstanceWithComResetConnectionPacket() throws SQLException {
+ public void assertNewInstanceWithComResetConnectionPacket() {
assertThat(MySQLCommandPacketFactory.newInstance(MySQLCommandPacketType.COM_RESET_CONNECTION, payload, connectionSession), instanceOf(MySQLUnsupportedCommandPacket.class));
}
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/hint/AddShardingHintDatabaseValueStatementAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/hint/AddShardingHintDatabaseValueStatementAssert.java
index 75c44e7498a..19cc44c8579 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/hint/AddShardingHintDatabaseValueStatementAssert.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/hint/AddShardingHintDatabaseValueStatementAssert.java
@@ -33,7 +33,7 @@ import static org.junit.Assert.assertNull;
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public class AddShardingHintDatabaseValueStatementAssert {
-
+
/**
* Assert add sharding hint database value statement is correct with expected parser result.
*