[GitHub] jlahoda commented on a change in pull request #453: Split into declaration and assignment issue for var type

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #453: Split into declaration and assignment issue for var type
URL: https://github.com/apache/incubator-netbeans/pull/453#discussion_r176929525
 
 

 ##########
 File path: java.source.base/src/org/netbeans/api/java/source/TreeUtilities.java
 ##########
 @@ -1850,7 +1850,23 @@ public boolean isCompileTimeConstantExpression(TreePath expression) {
         
         return ref.paramTypes;
     }
-    
+   
+    /**Check the var keyword in given statement line {@link Tree}.
+     * 
+     * @param leaf the leaf must be {@link Tree}
+     * @return the true if tree contains var keyword else return false.
+     */
+    public boolean isVarKeywordAvailable(@NonNull Tree leaf) {
 
 Review comment:
   Please rename the method to say the intent what it is doing, not how - i.e. "isVarVariable" or something like that. The point of having this method is that we can change the implementation if a better way is found. Add @since and increment spec.version.base (currently is 2.30.0, should be 2.31.0) in java.source.base/nbproject/project.properties. The parameter should either be VariableTree or a TreePath.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists