You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/01/28 02:47:49 UTC

Review Request 42892: GEODE-873: Allowing for possible retry in testParallelPregationHA

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42892/
-----------------------------------------------------------

Review request for geode, Barry Oglesby and xiaojian zhou.


Repository: geode


Description
-------

It's possible a put could be retried due to the member shutdown in this
test. If there is a retry, the stats may get incremented by one more
event.


Diffs
-----

  gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 4da0868da1d02008683ad1bbcec10f88f9ef77c2 

Diff: https://reviews.apache.org/r/42892/diff/


Testing
-------


Thanks,

Dan Smith


Re: Review Request 42892: GEODE-873: Allowing for possible retry in testParallelPregationHA

Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42892/#review116690
-----------------------------------------------------------


Ship it!




Ship It!

- Barry Oglesby


On Jan. 28, 2016, 1:47 a.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42892/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 1:47 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> It's possible a put could be retried due to the member shutdown in this
> test. If there is a retry, the stats may get incremented by one more
> event.
> 
> 
> Diffs
> -----
> 
>   gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 4da0868da1d02008683ad1bbcec10f88f9ef77c2 
> 
> Diff: https://reviews.apache.org/r/42892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>


Re: Review Request 42892: GEODE-873: Allowing for possible retry in testParallelPregationHA

Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42892/#review116687
-----------------------------------------------------------


Ship it!




Ship It!

- xiaojian zhou


On Jan. 28, 2016, 1:47 a.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42892/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 1:47 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> It's possible a put could be retried due to the member shutdown in this
> test. If there is a retry, the stats may get incremented by one more
> event.
> 
> 
> Diffs
> -----
> 
>   gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 4da0868da1d02008683ad1bbcec10f88f9ef77c2 
> 
> Diff: https://reviews.apache.org/r/42892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>