You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/19 10:26:37 UTC

[kudu-CR] KUDU-699 followup: fix flakiness of raft consensus quorum-test 

Hello Mike Percy, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5542

to review the following change.

Change subject: KUDU-699 followup: fix flakiness of raft_consensus_quorum-test
......................................................................

KUDU-699 followup: fix flakiness of raft_consensus_quorum-test

The fix for KUDU-699 introduced flakiness in this test. Now that
Peer::Close() doesn't block on outstanding requests, it's possible for
the test proxy's threadpool to get shut down while a request is
outstanding. This means that we now expect to sometimes get
"ServiceUnavailable" when submitting the response callbacks.

Before this patch, looping the test in DEBUG mode with 4 stress CPU
threads failed almost every task. Now it passed 100/100.

Change-Id: Id1c72d98b59b3c5a33b0a2d236a7c77b1ef1b9e3
---
M src/kudu/consensus/consensus-test-util.h
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/5542/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1c72d98b59b3c5a33b0a2d236a7c77b1ef1b9e3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] KUDU-699 followup: fix flakiness of raft consensus quorum-test

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: KUDU-699 followup: fix flakiness of raft_consensus_quorum-test
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c72d98b59b3c5a33b0a2d236a7c77b1ef1b9e3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-699 followup: fix flakiness of raft consensus quorum-test

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: KUDU-699 followup: fix flakiness of raft_consensus_quorum-test
......................................................................


KUDU-699 followup: fix flakiness of raft_consensus_quorum-test

The fix for KUDU-699 introduced flakiness in this test. Now that
Peer::Close() doesn't block on outstanding requests, it's possible for
the test proxy's threadpool to get shut down while a request is
outstanding. This means that we now expect to sometimes get
"ServiceUnavailable" when submitting the response callbacks.

Before this patch, looping the test in DEBUG mode with 4 stress CPU
threads failed almost every task. Now it passed 100/100.

Change-Id: Id1c72d98b59b3c5a33b0a2d236a7c77b1ef1b9e3
Reviewed-on: http://gerrit.cloudera.org:8080/5542
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/consensus-test-util.h
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1c72d98b59b3c5a33b0a2d236a7c77b1ef1b9e3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>