[jira] [Commented] (PROTON-712) Seg fault due to missing NULL return value check of getprotobyname

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172473#comment-14172473 ] 

ASF subversion and git services commented on PROTON-712:
--------------------------------------------------------

Commit 1632092 from rhs@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1632092 ]

PROTON-712: check getprotobyname for NULL return value (patch from Sahir Hoda)

> Seg fault due to missing NULL return value check of getprotobyname
> ------------------------------------------------------------------
>
>                 Key: PROTON-712
>                 URL: https://issues.apache.org/jira/browse/PROTON-712
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.7
>            Reporter: Sahir Hoda
>            Assignee: Rafael H. Schloming
>              Labels: easyfix, patch
>         Attachments: getprotobyname-err-check.patch
>
>
> There are several places proton-c makes calls to getprotobyname and dereferences the return value without checking for NULL first. Documentation for getprotobyname indicates it can return NULL if there was an error. We have seen seg faults in testing where getprotobyname returned NULL.
> Attached is a patch that adds some simple error checking to the getprotobyname call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)