You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2025/12/05 20:58:56 UTC
[PR] Modify LoadPlanTest to not compare serialized json for equality. [accumulo]
dlmarion opened a new pull request, #6008:
URL: https://github.com/apache/accumulo/pull/6008
Related to #5961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modify LoadPlanTest to not compare serialized json for equality. [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #6008:
URL: https://github.com/apache/accumulo/pull/6008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modify LoadPlanTest to not compare serialized json for equality. [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6008:
URL: https://github.com/apache/accumulo/pull/6008#discussion_r2623964886
##########
core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java:
##########
@@ -162,6 +162,33 @@ public byte[] getEndRow() {
public RangeType getRangeType() {
return rangeType;
}
+
+ @Override
+ public int hashCode() {
+ final int prime = 31;
+ int result = 1;
+ result = prime * result + Arrays.hashCode(endRow);
+ result = prime * result + Arrays.hashCode(startRow);
+ result = prime * result + Objects.hash(fileName, rangeType);
+ return result;
Review Comment:
Could simplify this to
```suggestion
return Objects.hash(Arrays.hashCode(endRow), Arrays.hashCode(startRow), fileName, rangeType);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org