You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/12/09 00:27:02 UTC
[GitHub] [druid] gianm opened a new pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
gianm opened a new pull request #10659:
URL: https://github.com/apache/druid/pull/10659
Objects like datasources and tasks are commonly used in znode paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] a2l007 commented on pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
a2l007 commented on pull request #10659:
URL: https://github.com/apache/druid/pull/10659#issuecomment-741835376
Curious but did you run across any related curator exceptions which prompted this fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10659:
URL: https://github.com/apache/druid/pull/10659#issuecomment-741938381
> Curious but did you run across any related curator exceptions which prompted this fix?
Not in production, but I was testing with a bunch of crazy characters to see what would happen and ran into this. #10645 and this patch both came from that effort. In a future patch I'd like to add all these crazy characters to the integration tests, but I didn't do it immediately, because I ran into problems with getting Maven to pass them along properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10659:
URL: https://github.com/apache/druid/pull/10659#issuecomment-741943977
And in a collaborative effort I have added this https://github.com/apache/druid/pull/10647/commits/4696d9c13d873b5a22a9ee00cc57a401617278ea#diff-038617639194a8d2235be0dd808371b8af5620f0b7d897c0a2adaff7eddc1f6bR41 to the web console e2e tests.
Partly because it tests characters that are apparently forbidden by maven 🤷♀️ ... JavaScript to the rescue I guess!
So these e2e tests open up the web console in a headless browser and create a datasource like ```load-data-from-local-disk-<=>+|!@#$%^&`'".,:;\*()[]{}Россия 한국 中国!?~2020-12-08T23:20:16.130Z```
and then query it:
this is a true e2e tests as it tests the web console also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #10659:
URL: https://github.com/apache/druid/pull/10659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky edited a comment on pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
vogievetsky edited a comment on pull request #10659:
URL: https://github.com/apache/druid/pull/10659#issuecomment-741943977
And in a collaborative effort I have added this https://github.com/apache/druid/pull/10647/commits/4696d9c13d873b5a22a9ee00cc57a401617278ea#diff-038617639194a8d2235be0dd808371b8af5620f0b7d897c0a2adaff7eddc1f6bR41 to the web console e2e tests.
Partly because it tests characters that are apparently forbidden by maven 🤷♀️ ... JavaScript to the rescue I guess!
So these e2e tests open up the web console in a headless browser and create a datasource like ```load-data-from-local-disk-<=>+|!@#$%^&`'".,:;\*()[]{}Россия 한국 中国!?~2020-12-08T23:20:16.130Z```
and then query it:
this is a true e2e test as it tests the web console also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10659:
URL: https://github.com/apache/druid/pull/10659#issuecomment-741963628
Wow. Glad that absolute unit of a datasource name works end to end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10659: IdUtils: Forbid characters that cannot be used in znodes.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10659:
URL: https://github.com/apache/druid/pull/10659#issuecomment-741964395
> forbidden by maven
Not necessarily forbidden, more that I just couldn't figure out how to get them escaped properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org