You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2014/05/01 00:47:42 UTC

[GitHub] spark pull request: SPARK-1639. Tidy up some Spark on YARN code

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/561#discussion_r12170125
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -328,22 +327,22 @@ trait ClientBase extends Logging {
           // If we are being launched in client mode, forward the spark-conf options
           // onto the executor launcher
           for ((k, v) <- sparkConf.getAll) {
    -        JAVA_OPTS += "-D" + k + "=" + "\\\"" + v + "\\\""
    +        javaOpts += "-D" + k + "=" + "\\\"" + v + "\\\""
    --- End diff --
    
    String interpolation would actually prettify this a bit:
      s"-D${k}=\"${v}\""


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---