You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/11/13 17:47:15 UTC
[PR] GH-44714: [C++] Keep field metadata for keys and values when importing a map type via the C data interface [arrow]
paleolimbot opened a new pull request, #44715:
URL: https://github.com/apache/arrow/pull/44715
### Rationale for this change
Import of a map type from the C data interface drops field metadata (including extension type information) which does not happen when importing a map type from IPC or a list of structs. This affects the ability to roundtrip data through pyarrow/Arrow C++ if extension types are not registered.
### What changes are included in this PR?
The mechanism to import the map type was changed to align with the method used for IPC import.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
The current behaviour was surprising/inconsistent, so I think this PR brings it in more line with the current expectation/documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44714: [C++] Keep field metadata for keys and values when importing a map type via the C data interface [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #44715:
URL: https://github.com/apache/arrow/pull/44715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44714: [C++] Keep field metadata for keys and values when importing a map type via the C data interface [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44715:
URL: https://github.com/apache/arrow/pull/44715#issuecomment-2474327682
:warning: GitHub issue #44714 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44714: [C++] Keep field metadata for keys and values when importing a map type via the C data interface [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44715:
URL: https://github.com/apache/arrow/pull/44715#issuecomment-2484239220
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 152e878a2e79877ec461f96cefc97663f0bc581f.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/33166210374) has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44714: [C++] Keep field metadata for keys and values when importing a map type via the C data interface [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44715:
URL: https://github.com/apache/arrow/pull/44715#issuecomment-2483139498
Thanks @paleolimbot . Do you think there should be a separate issue to add a corresponding integration test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org