You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/06/03 08:11:36 UTC
[GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/34
fix GEARPUMP-153, throw exception on main class load failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump GEARPUMP-153
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb
Author: manuzhang <ow...@gmail.com>
Date: 2016-06-03T08:08:07Z
fix GEARPUMP-153, throw exception on main class load failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #34: fix GEARPUMP-153, throw exception on main clas...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/34
## [Current coverage][cc-pull] is **64.16%**
> Merging [#34][cc-pull] into [master][cc-base-branch] will increase coverage by **0.63%**
1. 2 files (not in diff) in `...he/gearpump/jarstore` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F6A617273746F7265)
- Misses `+8`
- Hits `-8`
1. 2 files (not in diff) in `...mp/cluster/scheduler` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F7363686564756C6572)
1. 3 files (not in diff) in `...rpump/cluster/master` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D6173746572)
- Misses `+75`
- Hits `-75`
1. 3 files (not in diff) in `...earpump/cluster/main` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D61696E)
1. 1 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572)
- Misses `+1`
- Hits `-1`
1. 1 files (not in diff) in `.../org/apache/gearpump` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D70)
1. 6 files (not in diff) in `...apache/gearpump/util` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F7574696C)
- Misses `-32`
- Hits `+32`
1. 2 files (not in diff) in `...rpump/cluster/client` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F636C69656E74)
- Misses `-43`
- Hits `+43`
1. 2 files (not in diff) in `...mp/cluster/appmaster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6170706D6173746572)
- Misses `-9`
- Hits `+9`
1. 7 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572)
- Misses `-36`
- Hits `+36`
```diff
@@ master #34 diff @@
==========================================
Files 178 178
Lines 5922 5923 +1
Methods 5644 5651 +7
Messages 0 0
Branches 278 272 -6
==========================================
+ Hits 3761 3800 +39
+ Misses 2161 2123 -38
Partials 0 0
```
[][cc-pull]
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ec04cf7...d724ad6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/ec04cf7666020ba15764611ac872344549f5200c...d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb
[cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/34?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/34#discussion_r65672571
--- Diff: daemon/src/main/scala/org/apache/gearpump/cluster/main/AppSubmitter.scala ---
@@ -95,7 +94,8 @@ object AppSubmitter extends AkkaApp with ArgumentsParser {
val mainInManifest = Option(new JarFile(jar).getManifest.getMainAttributes.
getValue("Main-Class")).getOrElse("")
- if (remainArgs.length > 0 && Try(classLoader.loadClass(remainArgs(0))).isSuccess) {
+ if (remainArgs.length > 0) {
--- End diff --
What if I submit wordcount without the mainclass but specify other arguments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
Posted by manuzhang <gi...@git.apache.org>.
GitHub user manuzhang reopened a pull request:
https://github.com/apache/incubator-gearpump/pull/34
fix GEARPUMP-153, throw exception on main class load failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump GEARPUMP-153
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb
Author: manuzhang <ow...@gmail.com>
Date: 2016-06-03T08:08:07Z
fix GEARPUMP-153, throw exception on main class load failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #34: fix GEARPUMP-153, throw exception on main clas...
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on the issue:
https://github.com/apache/incubator-gearpump/pull/34
+1 I'm ok with requiring the main class to be named if you have arguments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/34#discussion_r65673527
--- Diff: daemon/src/main/scala/org/apache/gearpump/cluster/main/AppSubmitter.scala ---
@@ -95,7 +94,8 @@ object AppSubmitter extends AkkaApp with ArgumentsParser {
val mainInManifest = Option(new JarFile(jar).getManifest.getMainAttributes.
getValue("Main-Class")).getOrElse("")
- if (remainArgs.length > 0 && Try(classLoader.loadClass(remainArgs(0))).isSuccess) {
+ if (remainArgs.length > 0) {
--- End diff --
I don't think that should be allowed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---