[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

["Arshad Mohammad (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15477313#comment-15477313 ] 

Arshad Mohammad commented on ZOOKEEPER-2573:
--------------------------------------------

# shall we modify {{org.apache.zookeeper.version.Info.REVISION}} from int to String and store the git revision in it
 or introduce new variable {{org.apache.zookeeper.version.Info.GIT_REVISION}} for git revision?
# I would prefer to modify it from int to String, if there is no backward compatibility concern. It is not an exposed interface, so backward compatibility should be a concern here.

Any thoughts ?

> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
>                 Key: ZOOKEEPER-2573
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, server
>            Reporter: Arshad Mohammad
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo revision which is of type int
> But after migrating to git repo the git repo's revision(commit 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)