You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/13 12:17:38 UTC
[GitHub] [spark] panbingkun opened a new pull request, #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
panbingkun opened a new pull request, #38639:
URL: https://github.com/apache/spark/pull/38639
### What changes were proposed in this pull request?
The pr aims to upgrade mysql-connector-java from 8.0.30 to 8.0.31
### Why are the changes needed?
This version brings some bugs fixes, the release note as follows:
https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/news-8-0-31.html
Bugs Fixed, eg:
> Executing a PreparedStatment after applying setFetchSize(0) on it caused an ArrayIndexOutOfBoundsException. (Bug #104753, Bug #33286177)
<img width="839" alt="image" src="https://user-images.githubusercontent.com/15246973/201521236-d17cbdb4-080e-4b75-8667-b33f25ad613b.png">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38639:
URL: https://github.com/apache/spark/pull/38639#issuecomment-1314598737
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38639:
URL: https://github.com/apache/spark/pull/38639#discussion_r1020894403
##########
connector/docker-integration-tests/pom.xml:
##########
@@ -164,7 +164,7 @@
</dependency>
<dependency>
<groupId>mysql</groupId>
- <artifactId>mysql-connector-java</artifactId>
+ <artifactId>mysql-connector-j</artifactId>
Review Comment:
<img width="839" alt="image" src="https://user-images.githubusercontent.com/15246973/201521636-b8bc49d7-3cb7-45cf-be7c-e7099de313b4.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on a diff in pull request #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
Posted by GitBox <gi...@apache.org>.
bjornjorgensen commented on code in PR #38639:
URL: https://github.com/apache/spark/pull/38639#discussion_r1020913885
##########
connector/docker-integration-tests/pom.xml:
##########
@@ -164,7 +164,7 @@
</dependency>
<dependency>
<groupId>mysql</groupId>
Review Comment:
groupId: com.mysql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38639:
URL: https://github.com/apache/spark/pull/38639#issuecomment-1314711135
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38639: [SPARK-41123][BUILD] Upgrade mysql-connector-java from 8.0.30 to 8.0.31
URL: https://github.com/apache/spark/pull/38639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org