You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/11/03 23:37:16 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #958: ORC-1041: Fix the implementation of copy data blocks during LZO decompression

dongjoon-hyun commented on a change in pull request #958:
URL: https://github.com/apache/orc/pull/958#discussion_r742425222



##########
File path: c++/src/LzoDecompressor.cc
##########
@@ -312,13 +312,11 @@ namespace orc {
               output += SIZE_OF_INT;
               matchAddress += increment32;
 
-              *reinterpret_cast<int32_t*>(output) =
-                *reinterpret_cast<int32_t*>(matchAddress);
+              memcpy(output, matchAddress, SIZE_OF_INT);

Review comment:
       `reinterpret_cast` is a compile-time directive while `memcpy` is a run-time operation. I'm wondering if there is a potential performance regression.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org