You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Stas Bekman <st...@stason.org> on 2003/11/11 03:36:30 UTC
Re: cvs commit: httpd-apreq-2/build version_check.pl
joes@apache.org wrote:
> joes 2003/11/10 17:11:01
>
> Modified: . STATUS
> build version_check.pl
> Log:
> Prep for final release of 2.01_03-dev
>
> Revision Changes Path
> 1.34 +2 -2 httpd-apreq-2/STATUS
>
> Index: STATUS
> ===================================================================
> RCS file: /home/cvs/httpd-apreq-2/STATUS,v
> retrieving revision 1.33
> retrieving revision 1.34
> diff -u -r1.33 -r1.34
> --- STATUS 1 Nov 2003 19:17:29 -0000 1.33
> +++ STATUS 11 Nov 2003 01:11:01 -0000 1.34
> @@ -1,7 +1,7 @@
> Last modified at [$Date$] -*-text-*-
> /** @page STATUS
>
> - 2.01-dev in development
> + 2.01-dev tagged and rolled for release on November 10, 2003
>
> Contributors looking for a mission:
>
>
>
>
> 1.9 +1 -1 httpd-apreq-2/build/version_check.pl
>
> Index: version_check.pl
> ===================================================================
> RCS file: /home/cvs/httpd-apreq-2/build/version_check.pl,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -r1.8 -r1.9
> --- version_check.pl 8 Nov 2003 00:32:21 -0000 1.8
> +++ version_check.pl 11 Nov 2003 01:11:01 -0000 1.9
> @@ -50,7 +50,7 @@
> my %perl_glue = (
> perl => $build{perl},
> "Apache::Test" => { version => "1.04", test => \&a_t_version,
> - comment => "bundled with mod_perl 1.99_09" },
> + comment => "Win32 requires version 1.06" },
but it still checks for 1.04. Would it better to do?
my $apache_test_version = $^O eq 'MSWin32' ? "1.06" : "1.04";
...
"Apache::Test" => { version => $apache_test_version,
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: cvs commit: httpd-apreq-2/build version_check.pl
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:
> The Win32 section does use some parts of version_check.pl,
> which is very nice - one thing I'll work on is getting the
> top-level Makefile.PL to have not so many Win32 branches.
We should try to keep OS conditionals out of version_check.pl.
META.yml, which is a static file in the release package,
needs a list of prereqs that are OS independent.
> One thing though I'd like to perhaps keep is that, if
> Apache-Test and/or mod_perl isn't found, one could offer to
> install them via ppm, without having to quit.
+1- I'm hoping that someday CPAN will be able to do figure
that out right from the META.yml file, so the prereqs can be
installed by CPAN.pm before libapreq2 is even downloaded.
--
Joe Schaefer
Re: cvs commit: httpd-apreq-2/build version_check.pl
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 10 Nov 2003, Stas Bekman wrote:
> Joe Schaefer wrote:
> > Stas Bekman <st...@stason.org> writes:
> >
> > [...]
> >
> >>but it still checks for 1.04. Would it better to do?
> >>
> >> my $apache_test_version = $^O eq 'MSWin32' ? "1.06" : "1.04";
> >> ...
> >> "Apache::Test" => { version => $apache_test_version,
> >
> > Not in 2.01-dev, that code has already been voted on and sent
> > out the door.
>
> Sure.
>
> > I don't think Randy's Win32 build sytem uses version_check.pl,
> > so it's probably a moot point at the moment. However, 2.02-dev
> > is underway, so feel free to fire away at cvs. My schedule is quite
> > full this week, so I may not have much time for apreq-dev, other
> > than my usual silly comments on the list.
>
> Since I'm not on win32 and can't test it I'll leave it to
> Randy to commit ;)
The Win32 section does use some parts of version_check.pl,
which is very nice - one thing I'll work on is getting the
top-level Makefile.PL to have not so many Win32 branches.
One thing though I'd like to perhaps keep is that, if
Apache-Test and/or mod_perl isn't found, one could offer to
install them via ppm, without having to quit. This assumes
though ActivePerl, which isn't necessarily the case.
--
best regards,
randy
Re: cvs commit: httpd-apreq-2/build version_check.pl
Posted by Stas Bekman <st...@stason.org>.
Joe Schaefer wrote:
> Stas Bekman <st...@stason.org> writes:
>
> [...]
>
>
>>but it still checks for 1.04. Would it better to do?
>>
>> my $apache_test_version = $^O eq 'MSWin32' ? "1.06" : "1.04";
>> ...
>> "Apache::Test" => { version => $apache_test_version,
>
>
> Not in 2.01-dev, that code has already been voted on and sent
> out the door.
Sure.
> I don't think Randy's Win32 build sytem uses version_check.pl,
> so it's probably a moot point at the moment. However, 2.02-dev
> is underway, so feel free to fire away at cvs. My schedule is quite
> full this week, so I may not have much time for apreq-dev, other
> than my usual silly comments on the list.
Since I'm not on win32 and can't test it I'll leave it to Randy to commit ;)
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: cvs commit: httpd-apreq-2/build version_check.pl
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Stas Bekman <st...@stason.org> writes:
[...]
> but it still checks for 1.04. Would it better to do?
>
> my $apache_test_version = $^O eq 'MSWin32' ? "1.06" : "1.04";
> ...
> "Apache::Test" => { version => $apache_test_version,
Not in 2.01-dev, that code has already been voted on and sent
out the door.
I don't think Randy's Win32 build sytem uses version_check.pl,
so it's probably a moot point at the moment. However, 2.02-dev
is underway, so feel free to fire away at cvs. My schedule is quite
full this week, so I may not have much time for apreq-dev, other
than my usual silly comments on the list.
--
Joe Schaefer