You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2018/02/09 19:31:38 UTC

[24/28] tinkerpop git commit: TINKERPOP-1857 Fixed a bad has() GLV test

TINKERPOP-1857 Fixed a bad has() GLV test

Made test naming more consistent.


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/889c61d9
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/889c61d9
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/889c61d9

Branch: refs/heads/TINKERPOP-1857
Commit: 889c61d91077f07cdb529b662a1b983661d2f59e
Parents: 7e7aa8a
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Wed Feb 7 08:19:26 2018 -0500
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Fri Feb 9 14:30:59 2018 -0500

----------------------------------------------------------------------
 gremlin-test/features/filter/Has.feature                | 12 ++++++------
 .../gremlin/process/traversal/step/filter/HasTest.java  |  8 ++++----
 2 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/889c61d9/gremlin-test/features/filter/Has.feature
----------------------------------------------------------------------
diff --git a/gremlin-test/features/filter/Has.feature b/gremlin-test/features/filter/Has.feature
index 17f2716..ddf9984 100644
--- a/gremlin-test/features/filter/Has.feature
+++ b/gremlin-test/features/filter/Has.feature
@@ -127,12 +127,12 @@ Feature: Step - has()
     When iterated to list
     Then the result should be empty
 
-  Scenario: g_VX2X_hasXage_gt_30X
+  Scenario: g_VX4X_hasXage_gt_30X
     Given the modern graph
-    And using the parameter v2Id defined as "v[josh].id"
+    And using the parameter v4Id defined as "v[josh].id"
     And the traversal of
       """
-      g.V(v2Id).has("age", P.gt(30))
+      g.V(v4Id).has("age", P.gt(30))
       """
     When iterated to list
     Then the result should be unordered
@@ -149,13 +149,13 @@ Feature: Step - has()
     When iterated to list
     Then the result should be empty
 
-  Scenario: g_VXv2X_hasXage_gt_30X
+  Scenario: g_VXv4X_hasXage_gt_30X
     Given the modern graph
-    And using the parameter v4Id defined as "v[josh].id"
+    And using the parameter v4 defined as "v[josh]"
     And using the parameter d30 defined as "d[30].i"
     And the traversal of
       """
-      g.V(g.V(v4Id).next()).has("age", P.gt(d30))
+      g.V(v4).has("age", P.gt(d30))
       """
     When iterated to list
     Then the result should be unordered

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/889c61d9/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/HasTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/HasTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/HasTest.java
index deff30b..3bdb24a 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/HasTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/HasTest.java
@@ -218,7 +218,7 @@ public abstract class HasTest extends AbstractGremlinProcessTest {
 
     @Test
     @LoadGraphWith(MODERN)
-    public void g_VX2X_hasXage_gt_30X() {
+    public void g_VX4X_hasXage_gt_30X() {
         final Traversal<Vertex, Vertex> traversalJosh = get_g_VX1X_hasXage_gt_30X(convertToVertexId("josh"));
         printTraversalForm(traversalJosh);
         assertTrue(traversalJosh.hasNext());
@@ -227,15 +227,15 @@ public abstract class HasTest extends AbstractGremlinProcessTest {
     @Test
     @LoadGraphWith(MODERN)
     public void g_VXv1X_hasXage_gt_30X() {
-        final Traversal<Vertex, Vertex> traversalMarko = get_g_VXv1X_hasXage_gt_30X(convertToVertexId("marko"));
+        final Traversal<Vertex, Vertex> traversalMarko = get_g_VXv1X_hasXage_gt_30X(convertToVertex(graph,"marko"));
         printTraversalForm(traversalMarko);
         assertFalse(traversalMarko.hasNext());
     }
 
     @Test
     @LoadGraphWith(MODERN)
-    public void g_VXv2X_hasXage_gt_30X() {
-        final Traversal<Vertex, Vertex> traversalJosh = get_g_VXv1X_hasXage_gt_30X(convertToVertexId("josh"));
+    public void g_VXv4X_hasXage_gt_30X() {
+        final Traversal<Vertex, Vertex> traversalJosh = get_g_VXv1X_hasXage_gt_30X(convertToVertex(graph,"josh"));
         printTraversalForm(traversalJosh);
         assertTrue(traversalJosh.hasNext());
     }