[GitHub] [arrow] LouisClt commented on pull request #14806: ARROW-18421: [C++][ORC] Add accessor for number of rows by stripe in reader

[GitBox <gi...@apache.org>]

LouisClt commented on PR #14806:
URL: https://github.com/apache/arrow/pull/14806#issuecomment-1339031700

   Yes, why not.
   The structure storing the different informations available is located only in the implementation :
   ```
   struct StripeInformation {
     uint64_t offset;
     uint64_t length;
     uint64_t num_rows;
     uint64_t first_row_of_stripe;
   };
   ```
   The offset is the number of bytes since the beginning of the fil, in bytes, the length is the size of the stripe in bytes, the num_rows is the number of rows in the stripe, and "first_row_of_strip" is the index of the first row in the stripe (thus the sum of the num_rows of all the preceding stripes).
   We could just put the definition of this struct in the header, with comments on the use of each of these members, and return this struct in the getter.
   But maybe some members would benefit from a renaming...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org