You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "raphinesse (GitHub)" <gi...@apache.org> on 2018/08/26 21:17:35 UTC

[GitHub] [cordova-lib] raphinesse opened pull request #665: Radically focused restore.spec finally fast and reliable

### Pro
- Runtime: 217s -> 2s (on my machine)
- No dependency on the network
- Easier tests

### Con
- Code coverage caused by this test is considerably smaller
    - but it has no big overall impact; see below

Test names and comments will still have to be edited a bit if we want to merge this, but I first wanted to know what you think about this change.

|          |  % Stmts | % Branch |  % Funcs |  % Lines |
|----------|----------|----------|----------|----------|
| Before   |    80.29 |    75.93 |    72.66 |     80.8 |
| After    |    80.23 |     75.6 |    72.66 |    80.73 |


[ Full content available at: https://github.com/apache/cordova-lib/pull/665 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] raphinesse commented on issue #665: Radically focused restore.spec finally fast and reliable

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
This should also resolve the test failures for #622 

[ Full content available at: https://github.com/apache/cordova-lib/pull/665 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] codecov-io commented on issue #665: Radically focused restore.spec finally fast and reliable

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=h1) Report
> Merging [#665](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b77f5aeeab61e6d0a0691cfb587af298861dc215?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/665/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   80.79%   80.72%   -0.07%     
==========================================
  Files          57       57              
  Lines        3015     3015              
==========================================
- Hits         2436     2434       -2     
- Misses        579      581       +2
```


| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/665/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `88.6% <0%> (-1.48%)` | :arrow_down: |
| [src/cordova/platform/addHelper.js](https://codecov.io/gh/apache/cordova-lib/pull/665/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGxhdGZvcm0vYWRkSGVscGVyLmpz) | `96.36% <0%> (-0.61%)` | :arrow_down: |
| [src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/665/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz) | `95.75% <0%> (+1.41%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=footer). Last update [b77f5ae...93ff36a](https://codecov.io/gh/apache/cordova-lib/pull/665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/cordova-lib/pull/665 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] raphinesse closed pull request #665: Radically focused restore.spec finally fast and reliable

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
[ pull request closed by raphinesse ]

[ Full content available at: https://github.com/apache/cordova-lib/pull/665 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org