You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "Martin Tzvetanov Grigorov (Jira)" <ji...@apache.org> on 2022/10/14 10:06:00 UTC

[jira] [Resolved] (AVRO-3639) [Rust] Derive implementation for Eq where possible

     [ https://issues.apache.org/jira/browse/AVRO-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Tzvetanov Grigorov resolved AVRO-3639.
---------------------------------------------
    Fix Version/s: 1.12.0
                   1.11.2
       Resolution: Fixed

> [Rust] Derive implementation for Eq where possible
> --------------------------------------------------
>
>                 Key: AVRO-3639
>                 URL: https://issues.apache.org/jira/browse/AVRO-3639
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Minor
>             Fix For: 1.12.0, 1.11.2
>
>
> Rust nightly clippy reports errors like:
> {code:java}
> error: you are deriving `PartialEq` and can implement `Eq`
>     --> avro_derive/tests/derive.rs:1081:64
>      |
> 1081 |     #[derive(Debug, Serialize, Deserialize, AvroSchema, Clone, PartialEq)]
>      |                                                                ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
>      |
>      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
>  {code}
>  
> Most of those errors are in test code but anyway it would be good to fix them!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)