You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2017/12/01 23:19:54 UTC
Review Request 64273: SENTRY-2084: Exclude javax.jms:jms from sentry
distribution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64273/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov and Sergio Pena.
Bugs: SENTRY-2084
https://issues.apache.org/jira/browse/SENTRY-2084
Repository: sentry
Description
-------
we need to stop distributing jms artifact with group id: javax.jms as these no valid valid license information available for this jar and secondly it is a transitive dependency which sentry is not dependent on.
This code change makes sure that we dont distrubute javax.jms:jms
Diffs
-----
pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631
Diff: https://reviews.apache.org/r/64273/diff/1/
Testing
-------
Made sure that the jar is not part of the sentry distribution.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 64273: SENTRY-2084: Exclude javax.jms:jms from
sentry distribution
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64273/#review192595
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Dec. 1, 2017, 11:19 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64273/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 11:19 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Sergio Pena.
>
>
> Bugs: SENTRY-2084
> https://issues.apache.org/jira/browse/SENTRY-2084
>
>
> Repository: sentry
>
>
> Description
> -------
>
> we need to stop distributing jms artifact with group id: javax.jms as these no valid valid license information available for this jar and secondly it is a transitive dependency which sentry is not dependent on.
> This code change makes sure that we dont distrubute javax.jms:jms
>
>
> Diffs
> -----
>
> pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631
>
>
> Diff: https://reviews.apache.org/r/64273/diff/1/
>
>
> Testing
> -------
>
> Made sure that the jar is not part of the sentry distribution.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 64273: SENTRY-2084: Exclude javax.jms:jms from
sentry distribution
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64273/#review192596
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
pom.xml
Lines 734 (patched)
<https://reviews.apache.org/r/64273/#comment270851>
Please add comment explaining why this is excluded
- Alexander Kolbasov
On Dec. 1, 2017, 11:19 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64273/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 11:19 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Sergio Pena.
>
>
> Bugs: SENTRY-2084
> https://issues.apache.org/jira/browse/SENTRY-2084
>
>
> Repository: sentry
>
>
> Description
> -------
>
> we need to stop distributing jms artifact with group id: javax.jms as these no valid valid license information available for this jar and secondly it is a transitive dependency which sentry is not dependent on.
> This code change makes sure that we dont distrubute javax.jms:jms
>
>
> Diffs
> -----
>
> pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631
>
>
> Diff: https://reviews.apache.org/r/64273/diff/1/
>
>
> Testing
> -------
>
> Made sure that the jar is not part of the sentry distribution.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>