You are viewing a plain text version of this content. The canonical link for it is here.

Posted to codereview@trafodion.apache.org by DaveBirdsall <gi...@git.apache.org> on 2015/12/01 19:08:58 UTC

[GitHub] incubator-trafodion pull request: [TRAFODION-1645] add support to ...

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/194#discussion_r46314687
  
    --- Diff: core/sql/comexe/ComTdbExeUtil.h ---
    @@ -3452,6 +3453,122 @@ class ComTdbExeUtilHBaseBulkUnLoad : public ComTdbExeUtil
       NABasicPtr   snapshotSuffix_;                         // 30 - 37
       char         fillersExeUtilHbaseUnLoad_[16];          // 38 - 53
     };
    +
    +static const ComTdbVirtTableColumnInfo comTdbRegionStatsVirtTableColumnInfo[] =
    +  {
    +    { "CATALOG_NAME",                   0, COM_USER_COLUMN, REC_BYTE_F_ASCII,  256, FALSE, SQLCHARSETCODE_UTF8 , 0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "",NULL,NULL, COM_UNKNOWN_DIRECTION_LIT, 0  },
    --- End diff --
    
    Just curious: Why fixed length CHAR instead of VARCHAR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---