You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/04/12 23:35:00 UTC
Review Request 20284: Fixed post-reviews script to use 'rbt post' in favor
of deprecated post-review.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Bugs: MESOS-931
https://issues.apache.org/jira/browse/MESOS-931
Repository: mesos-git
Description
-------
Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
Diffs
-----
support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
Diff: https://reviews.apache.org/r/20284/diff/
Testing
-------
Used it post this review.
Thanks,
Vinod Kone
Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' in
favor of deprecated post-review.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/#review40217
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20284]
All tests passed.
- Mesos ReviewBot
On April 12, 2014, 9:34 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20284/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 9:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-931
> https://issues.apache.org/jira/browse/MESOS-931
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20284/diff/
>
>
> Testing
> -------
>
> Used it post this review.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' in
favor of deprecated post-review.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/#review40336
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 12, 2014, 9:34 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20284/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 9:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-931
> https://issues.apache.org/jira/browse/MESOS-931
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20284/diff/
>
>
> Testing
> -------
>
> Used it post this review.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' in
favor of deprecated post-review.
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/#review40342
-----------------------------------------------------------
RBTools 0.5.4 released 3 months ago, so with this change, we'll depends on a quite new version of RBTools. This is generally not OK for distro packages. I'd like to keep use post-review, if not found (in the incoming RBTools 0.6.x, which will be obsolete as it says), then try rbt.
Another comment for this patch is the comments in file head should be updated too, it still says something about *post-review* rather than *rbt*.
- Chengwei Yang
On April 13, 2014, 5:34 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20284/
> -----------------------------------------------------------
>
> (Updated April 13, 2014, 5:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-931
> https://issues.apache.org/jira/browse/MESOS-931
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20284/diff/
>
>
> Testing
> -------
>
> Used it post this review.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' when
'post-review' is not available.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/#review42100
-----------------------------------------------------------
Ship it!
Rad, thanks Vinod.
- Benjamin Hindman
On May 3, 2014, 7:53 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20284/
> -----------------------------------------------------------
>
> (Updated May 3, 2014, 7:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-931
> https://issues.apache.org/jira/browse/MESOS-931
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
>
>
> Diffs
> -----
>
> support/post-reviews.py 89ea779e856ef8c62819a45f3a942609baa75142
>
> Diff: https://reviews.apache.org/r/20284/diff/
>
>
> Testing
> -------
>
> Used it post this review.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' when
'post-review' is not available.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/
-----------------------------------------------------------
(Updated May 3, 2014, 7:53 p.m.)
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Changes
-------
Updated to use 'rbt post' if 'post-review' is not available. This should make it backwards compatible.
Summary (updated)
-----------------
Fixed post-reviews script to use 'rbt post' when 'post-review' is not available.
Bugs: MESOS-931
https://issues.apache.org/jira/browse/MESOS-931
Repository: mesos-git
Description
-------
Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
Diffs (updated)
-----
support/post-reviews.py 89ea779e856ef8c62819a45f3a942609baa75142
Diff: https://reviews.apache.org/r/20284/diff/
Testing
-------
Used it post this review.
Thanks,
Vinod Kone