You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2008/09/03 00:10:31 UTC
Re: svn commit: r691359 [1/8] - in /tomcat/trunk: ./ java/org/apache/cometd/
java/org/apache/cometd/bayeux/ java/org/apache/tomcat/bayeux/ java/org/apache/tomcat/bayeux/request/
test/org/apache/cometd/ test/org/apache/cometd/bayeux/ test/org/apache/cometd/...
Remy Maucherat wrote:
> +****For the bayeux implementation*********
> +* Copyright 2007-2008 Guy Molinari
> +* Copyright 2007-2008 Filip Hanik
> +* Copyright 2007 Dojo Foundation
> +* Copyright 2007 Mort Bay Consulting Pty. Ltd.
>
> Personally, I don't like that. As far as I am concerned, I like the code
> in ASF repositories to be (c) ASF, as it's always been.
That isn't the case. The collective work is (c) ASF but individual
contributions are (c) to the committer / contributor that provided them. I
may not have used exactly the right language to express this - the
legal-dicuss list is the place to get a better answer.
That said, the COPYRIGHT file needs to go. That information should be in
NOTICE.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r691359 [1/8] - in /tomcat/trunk: ./ java/org/apache/cometd/
java/org/apache/cometd/bayeux/ java/org/apache/tomcat/bayeux/ java/org/apache/tomcat/bayeux/request/
test/org/apache/cometd/ test/org/apache/cometd/bayeux/ test/org/apache/cometd/...
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Remy Maucherat wrote:
> On Tue, 2008-09-02 at 23:37 +0100, Mark Thomas wrote:
>
>> Therefore, I vote -1 for this contribution as it does not comply with the
>> published ASF source headers policy. I am happy for this contribution to
>> remain in trunk providing that the necessary changes are made in a
>> reasonable time scale.
>>
>
> I will look at this. There's obviously no need to revert for now (esp
> since it doing it too much would kill my email).
>
I have no problem reverting, if we are not comfortable.
The org.apache.cometd.bayeux is an API derived from the works over at
Dojo Foundation.
It was under this URL
https://svn.codehaus.org/jetty-contrib/jetty/trunk/contrib/cometd/api/src/main/java/dojox/cometd
But that code base is no longer available.
So what we did, was take what we like, remove a bunch of stuff and
rework the API into what we thought be more usable to the Tomcat project.
The reason for this was that we waited for very long for to contribute
to a shared API, and simply write our implementation against a standard
API (something I would still like to do if it can happen)
If we are not comfortable with that, I can revert the change and we can
discuss the way we want to approach this
Filip
> Rémy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r691359 [1/8] - in
/tomcat/trunk: ./ java/org/apache/cometd/
java/org/apache/cometd/bayeux/ java/org/apache/tomcat/bayeux/ java/org/apache/tomcat/bayeux/request/
test/org/apache/cometd/ test/org/apache/cometd/bayeux/ test/org/apache/cometd/...
Posted by Remy Maucherat <re...@apache.org>.
On Tue, 2008-09-02 at 23:37 +0100, Mark Thomas wrote:
> Therefore, I vote -1 for this contribution as it does not comply with the
> published ASF source headers policy. I am happy for this contribution to
> remain in trunk providing that the necessary changes are made in a
> reasonable time scale.
I will look at this. There's obviously no need to revert for now (esp
since it doing it too much would kill my email).
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r691359 [1/8] - in /tomcat/trunk: ./ java/org/apache/cometd/
java/org/apache/cometd/bayeux/ java/org/apache/tomcat/bayeux/ java/org/apache/tomcat/bayeux/request/
test/org/apache/cometd/ test/org/apache/cometd/bayeux/ test/org/apache/cometd/...
Posted by Mark Thomas <ma...@apache.org>.
Mark Thomas wrote:
> Therefore, I vote -1 for this contribution as it does not comply with the
> published ASF source headers policy. I am happy for this contribution to
> remain in trunk providing that the necessary changes are made in a
> reasonable time scale.
I have re-read the policy and the .js files can be considered a third
party work so they are fine. The only real issue was the COPYRIGHT file
and that has been fixed so I withdraw my -1.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r691359 [1/8] - in /tomcat/trunk: ./ java/org/apache/cometd/
java/org/apache/cometd/bayeux/ java/org/apache/tomcat/bayeux/ java/org/apache/tomcat/bayeux/request/
test/org/apache/cometd/ test/org/apache/cometd/bayeux/ test/org/apache/cometd/...
Posted by Mark Thomas <ma...@apache.org>.
Remy Maucherat wrote:
> On Tue, 2008-09-02 at 23:10 +0100, Mark Thomas wrote:
>> Remy Maucherat wrote:
>>> +****For the bayeux implementation*********
>>> +* Copyright 2007-2008 Guy Molinari
>>> +* Copyright 2007-2008 Filip Hanik
>>> +* Copyright 2007 Dojo Foundation
>>> +* Copyright 2007 Mort Bay Consulting Pty. Ltd.
>>>
>>> Personally, I don't like that. As far as I am concerned, I like the code
>>> in ASF repositories to be (c) ASF, as it's always been.
>> That isn't the case. The collective work is (c) ASF but individual
>> contributions are (c) to the committer / contributor that provided them. I
>> may not have used exactly the right language to express this - the
>> legal-dicuss list is the place to get a better answer.
>
> Is this code also (c) ASF then, in addition to the people listed ? (= if
> the code is copied, can it be only labelled (c) ASF ?)
It is the collective work that is copyright ASF. This is stated in the
notice file. We can only change/remove copyright notices in very specific
circumstances.
> If yes, then +1 for the code, otherwise -1 (please gives pointers to
> where this is approved and in which projects it has been done).
http://www.apache.org/legal/src-headers.html should answer all your questions.
Looking at some other files there are a number of issues with copyright
notices that need to be fixed in addition to the removal of the COPYRIGHT file.
Therefore, I vote -1 for this contribution as it does not comply with the
published ASF source headers policy. I am happy for this contribution to
remain in trunk providing that the necessary changes are made in a
reasonable time scale.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r691359 [1/8] - in /tomcat/trunk:
./ java/org/apache/cometd/
java/org/apache/cometd/bayeux/ java/org/apache/tomcat/bayeux/
java/org/apache/tomcat/bayeux/request/ test/org/apache/cometd/
test/org/apache/cometd/bayeux/ test/org/apache/cometd/...
Posted by Remy Maucherat <re...@apache.org>.
On Tue, 2008-09-02 at 23:10 +0100, Mark Thomas wrote:
> Remy Maucherat wrote:
> > +****For the bayeux implementation*********
> > +* Copyright 2007-2008 Guy Molinari
> > +* Copyright 2007-2008 Filip Hanik
> > +* Copyright 2007 Dojo Foundation
> > +* Copyright 2007 Mort Bay Consulting Pty. Ltd.
> >
> > Personally, I don't like that. As far as I am concerned, I like the code
> > in ASF repositories to be (c) ASF, as it's always been.
>
> That isn't the case. The collective work is (c) ASF but individual
> contributions are (c) to the committer / contributor that provided them. I
> may not have used exactly the right language to express this - the
> legal-dicuss list is the place to get a better answer.
Is this code also (c) ASF then, in addition to the people listed ? (= if
the code is copied, can it be only labelled (c) ASF ?)
If yes, then +1 for the code, otherwise -1 (please gives pointers to
where this is approved and in which projects it has been done).
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org