You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/02/17 18:00:59 UTC
[superset] 02/02: working test
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/sqlalchemy-docs-2
in repository https://gitbox.apache.org/repos/asf/superset.git
commit a9aabf837dff14fde08aa9ae213cc6f900870207
Author: hughhhh <hu...@gmail.com>
AuthorDate: Wed Feb 17 13:00:13 2021 -0500
working test
---
superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
index f2541da..98b83cc 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
@@ -51,6 +51,7 @@ interface RootState {
}
const DEFAULT_TAB_KEY = '1';
+const DEFAULT_SQLALCHEMY_DOCS_URL = "https://docs.sqlalchemy.org/en/rel_1_2/core/engines.html#"
const StyledIcon = styled(Icon)`
margin: auto ${({ theme }) => theme.gridUnit * 2}px auto 0;
@@ -417,7 +418,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
<div className="helper">
{t('Refer to the ')}
<a
- href={conf.SQLALCHEMY_DOCS_URL ? conf.SQLALCHEMY_DOCS_URL : ''}
+ href={conf?.SQLALCHEMY_DOCS_URL ?? DEFAULT_SQLALCHEMY_DOCS_URL}
target="_blank"
rel="noopener noreferrer"
>