You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/04/10 15:34:06 UTC

[GitHub] [submarine] cchung100m opened a new pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

cchung100m opened a new pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259
 
 
   ### What is this PR for?
   
   The `bin/submarine-daemon.sh` script should create path `submarine/lib` if user type 
   
   `./bin/submarine-daemon.sh start getMysqlJar`
   
   without creating `submarine/lib` directory first.
   
   
   ### What type of PR is it?
   [Improvement]
   
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/SUBMARINE-466
   
   ### How should this be tested?
   
   https://travis-ci.com/github/cchung100m/submarine/builds/159802797
   
   ### Screenshots (if appropriate)
   
   <img width="921" alt="螢幕快照 2020-04-10 下午11 24 30" src="https://user-images.githubusercontent.com/6762509/79002610-6560db00-7b83-11ea-8ea3-ca10beca15c0.png">
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#discussion_r407007741
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -91,7 +91,14 @@ function wait_for_submarine_server_to_die() {
 }
 
 function check_jdbc_jar() {
-  if [[ -d "${1}" ]]; then
+  if [[ ! -e "${1}" ]]; then
+    echo -e "\\033[31mError: Path '${1}' doesn't exist.\\033[0m"
 
 Review comment:
   Updated, thanks for the review. @jojochuang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jiwq commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
jiwq commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612454621
 
 
   @cchung100m As I know this script only used under the dist folder, layout like below:
   ```
   |submarine-dist-0.4.0-SNAPSHOT-hadoop-2.9
   |--bin/
   |--conf/
   |--dev-support/
   |--docs/
   |--lib/
   |--licenses/
   |--submarine-cloud/
   |--LICENSE
   |--NOTICE
   ```
   If you want to start submarine server, you'd better under the dist directory(`submarine-dist/target/submarine-dist-*-SNAPSHOT-hadoop-2.9/submarine-dist-*-SNAPSHOT-hadoop-2.9`) to execute `./bin/submarine-daemon.sh start getMysqlJar` command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612551874
 
 
   Hi @jiwq 
   
   Thanks for the review. 
   Actually, this PR is going to build the relative path `${BIN}/../lib` if it does not exist. 
   Sorry for my incorrect description at first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m closed pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m closed pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jojochuang commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612326496
 
 
   Actually, the test failed for the mysql jar issue
   
   ### Cause: java.sql.SQLException: Error setting driver on UnpooledDataSource. Cause: java.lang.ClassNotFoundException: Cannot find class: com.mysql.jdbc.Driver
   
   could you check again if it is related at all?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jiwq removed a comment on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
jiwq removed a comment on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612454621
 
 
   @cchung100m As I know this script only used under the dist folder, layout like below:
   ```
   |submarine-dist-0.4.0-SNAPSHOT-hadoop-2.9
   |--bin/
   |--conf/
   |--dev-support/
   |--docs/
   |--lib/
   |--licenses/
   |--submarine-cloud/
   |--LICENSE
   |--NOTICE
   ```
   If you want to start submarine server, you'd better under the dist directory(`submarine-dist/target/submarine-dist-*-SNAPSHOT-hadoop-2.9/submarine-dist-*-SNAPSHOT-hadoop-2.9`) to execute `./bin/submarine-daemon.sh start getMysqlJar` command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jojochuang commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#discussion_r406817963
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -91,7 +91,14 @@ function wait_for_submarine_server_to_die() {
 }
 
 function check_jdbc_jar() {
-  if [[ -d "${1}" ]]; then
+  if [[ ! -e "${1}" ]]; then
+    echo -e "\\033[31mError: Path '${1}' doesn't exist.\\033[0m"
 
 Review comment:
   it should a a Warn not Error since it is correctable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612348057
 
 
   Hi @jojochuang 
   
   I re-trigger the e2e job and it is successful with this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612083143
 
 
   cc @liuxunorg  @kevin85421 @pingsutw 
   
   TIA if you are available to review/manage this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612559230
 
 
   Hi @jiwq @liuxunorg 
   
   Thanks for your patience and interpretation.
   
   I did misunderstand the `bin/submarine-daemon.sh` script's working before, but I get it now.
   
   Thanks again.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jojochuang commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#discussion_r406817963
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -91,7 +91,14 @@ function wait_for_submarine_server_to_die() {
 }
 
 function check_jdbc_jar() {
-  if [[ -d "${1}" ]]; then
+  if [[ ! -e "${1}" ]]; then
+    echo -e "\\033[31mError: Path '${1}' doesn't exist.\\033[0m"
 
 Review comment:
   it should a a Warn not Error

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] cchung100m commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
cchung100m commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#discussion_r407007853
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -91,7 +91,14 @@ function wait_for_submarine_server_to_die() {
 }
 
 function check_jdbc_jar() {
-  if [[ -d "${1}" ]]; then
+  if [[ ! -e "${1}" ]]; then
+    echo -e "\\033[31mError: Path '${1}' doesn't exist.\\033[0m"
 
 Review comment:
   <img width="914" alt="螢幕快照 2020-04-11 上午10 42 30" src="https://user-images.githubusercontent.com/6762509/79033600-f5357200-7be1-11ea-840d-3de18dc1845b.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jiwq commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

Posted by GitBox <gi...@apache.org>.
jiwq commented on issue #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#issuecomment-612555221
 
 
   Hi @cchung100m , thanks for your contribution.
   > Actually, this PR is going to build the relative path `${BIN}/../lib` if it does not exist.
   
   Which situation can caused this path not exist? This script can not work well if this case exists. Because in this script we call `add_jar_in_dir ${BIN}/../lib` first to add all the jars to classpath.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services