You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2022/06/06 15:04:00 UTC
[jira] [Resolved] (HIVE-26289) Remove useless try catch in DataWritableReadSupport#getWriterDateProleptic
[ https://issues.apache.org/jira/browse/HIVE-26289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stamatis Zampetakis resolved HIVE-26289.
----------------------------------------
Fix Version/s: 4.0.0-alpha-2
Resolution: Fixed
Fixed in [https://github.com/apache/hive/commit/cdb1052e24ca493c6486fef3dd8956dde61be834.] Thanks for the review [~ayushsaxena] !
> Remove useless try catch in DataWritableReadSupport#getWriterDateProleptic
> --------------------------------------------------------------------------
>
> Key: HIVE-26289
> URL: https://issues.apache.org/jira/browse/HIVE-26289
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> try {
> if (value != null) {
> return Boolean.valueOf(value);
> }
> } catch (DateTimeException e) {
> throw new RuntimeException("Can't parse writer proleptic property stored in file metadata", e);
> }
> {code}
> The Boolean.valueOf never throws so try catch block is completely useless.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)