You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/10/25 12:32:46 UTC

[GitHub] flink pull request #4902: [FLINK-7846] [elasticsearch] Remove unnecessary gu...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4902

    [FLINK-7846] [elasticsearch] Remove unnecessary guava shading

    2nd attempt of #4834, which i accidentally closed while merging another commit.
    
    ## What is the purpose of the change
    
    This PR removes the guava shading from the ES2 connector. The shading is pointless since the only possible guava user is the elasticsearch dependency, which is not included in the jar, and thus unaffected by the shading.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7846

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4902.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4902
    
----
commit 82436bfd11c586f639917f4f38422cbeb5dbe408
Author: zentol <ch...@apache.org>
Date:   2017-10-16T11:49:55Z

    [FLINK-7846] [elasticsearch] Remove unnecessary guava shading

----


---

[GitHub] flink pull request #4902: [FLINK-7846] [elasticsearch] Remove unnecessary gu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4902


---

[GitHub] flink issue #4902: [FLINK-7846] [elasticsearch] Remove unnecessary guava sha...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4902
  
    Looks good, +1 to merge this


---