Remove SDK commands from CLI?

[James Thomas <jt...@gmail.com>]

Does anyone have any objections to removing the "SDK" command from the wsk
cli?

I came across this "feature" again recently due to a user running into
issues trying to use docker support in the platform. I've recently been
updating the docs on the docker actions and think we should remove this
command as it doesn't represent best practice for the platform anymore.

The SDK was an old solution to utilising custom runtime images in the
beginning of the project, before the docker support improved a lot. The
"SDKs" are a series of old tar files download from the external source
repository. Looking at the Docker SDK, it does not represent a sensible
approach to using binaries on the platform now we have the dockerskeleton
image. I didn't investigate the Swift SDK and wouldn't be sure if this even
works anymore....

I've never come across an external developer using these SDKs "in the wild"
and can't see a valid use-case for continuing to provide them given all the
changes in the platform since they were introduced.

Does anyone have any comments? If not, I'll open a PR in the CLI to start
removing them.
-- 
Regards,
James Thomas

Re: Remove SDK commands from CLI?

[Carlos Santana <cs...@gmail.com>]

+1

Folks should extending the current runtimes per language and not the docker sdk. 

For Swift it’s also ok to remove it as it’s not being maintained as no one is using it, and it doesn’t make sense to use it anymore since we have webactions and apigateway. 


- Carlos Santana
@csantanapr

On Apr 19, 2019, at 3:04 PM, Rodric Rabbah <ro...@gmail.com> wrote:

>> I didn't investigate the Swift SDK and wouldn't be sure if this even
> works anymore....
> 
> There used to be a jenkins build for this but odds are it's rotted and we
> should also remove it.
> 
> -r

Re: Remove SDK commands from CLI?

[Rodric Rabbah <ro...@gmail.com>]

> I didn't investigate the Swift SDK and wouldn't be sure if this even
works anymore....

There used to be a jenkins build for this but odds are it's rotted and we
should also remove it.

-r

Re: Remove SDK commands from CLI?

[Shazron <sh...@gmail.com>]

While you're at it, remove this as well:
https://github.com/apache/incubator-openwhisk-cli/issues/119

On Tue, Apr 23, 2019 at 2:14 AM Carlos Santana <cs...@gmail.com> wrote:

> Use the opportunity to clean the nginx routes, CLI was the only consumer
>
> - Carlos Santana
> @csantanapr
>
> > On Apr 22, 2019, at 2:02 PM, David P Grove <gr...@us.ibm.com> wrote:
> >
> >
> > +1 to remove them.
> >
> > Does that also let us remove the routes from the nginx file in the main
> > repo [1]?
> >
> > --dave
> >
> > [1]
> >
> https://github.com/apache/incubator-openwhisk/blob/master/ansible/roles/nginx/templates/nginx.conf.j2#L140-#L146
> >
> > James Thomas <jt...@gmail.com> wrote on 04/18/2019 12:58:38 PM:
> >>
> >> Does anyone have any objections to removing the "SDK" command from the
> > wsk
> >> cli?
> >>
>

Re: Remove SDK commands from CLI?

[Carlos Santana <cs...@gmail.com>]

Use the opportunity to clean the nginx routes, CLI was the only consumer

- Carlos Santana
@csantanapr

> On Apr 22, 2019, at 2:02 PM, David P Grove <gr...@us.ibm.com> wrote:
> 
> 
> +1 to remove them.
> 
> Does that also let us remove the routes from the nginx file in the main
> repo [1]?
> 
> --dave
> 
> [1]
> https://github.com/apache/incubator-openwhisk/blob/master/ansible/roles/nginx/templates/nginx.conf.j2#L140-#L146
> 
> James Thomas <jt...@gmail.com> wrote on 04/18/2019 12:58:38 PM:
>> 
>> Does anyone have any objections to removing the "SDK" command from the
> wsk
>> cli?
>> 

Re: Remove SDK commands from CLI?

[Rodric Rabbah <ro...@gmail.com>]

 > Does that also let us remove the routes from the nginx file in the main
repo [1]?

Yep - I see no reason to keep them and we should clean up the cli and nginx
code at the same time IMO.

-r

Re: Remove SDK commands from CLI?

[David P Grove <gr...@us.ibm.com>]

+1 to remove them.

Does that also let us remove the routes from the nginx file in the main
repo [1]?

--dave

[1]
https://github.com/apache/incubator-openwhisk/blob/master/ansible/roles/nginx/templates/nginx.conf.j2#L140-#L146

James Thomas <jt...@gmail.com> wrote on 04/18/2019 12:58:38 PM:
>
> Does anyone have any objections to removing the "SDK" command from the
wsk
> cli?
>

Re: Remove SDK commands from CLI?

[Rodric Rabbah <ro...@gmail.com>]

With the excellent rewrite of the docker instructions[1], I too think we
can remove the docker sdk from the cli (and nginx).

[1] https://github.com/apache/incubator-openwhisk/pull/4451

-r

On Thu, Apr 18, 2019 at 12:58 PM James Thomas <jt...@gmail.com> wrote:

> Does anyone have any objections to removing the "SDK" command from the wsk
> cli?
>
> I came across this "feature" again recently due to a user running into
> issues trying to use docker support in the platform. I've recently been
> updating the docs on the docker actions and think we should remove this
> command as it doesn't represent best practice for the platform anymore.
>
> The SDK was an old solution to utilising custom runtime images in the
> beginning of the project, before the docker support improved a lot. The
> "SDKs" are a series of old tar files download from the external source
> repository. Looking at the Docker SDK, it does not represent a sensible
> approach to using binaries on the platform now we have the dockerskeleton
> image. I didn't investigate the Swift SDK and wouldn't be sure if this even
> works anymore....
>
> I've never come across an external developer using these SDKs "in the wild"
> and can't see a valid use-case for continuing to provide them given all the
> changes in the platform since they were introduced.
>
> Does anyone have any comments? If not, I'll open a PR in the CLI to start
> removing them.
> --
> Regards,
> James Thomas
>