[GitHub] [tez] abstractdog commented on a diff in pull request #192: TEZ-4363: Bump protobuf dependency to 3.x

[GitBox <gi...@apache.org>]

abstractdog commented on code in PR #192:
URL: https://github.com/apache/tez/pull/192#discussion_r862622055


##########
tez-dag/src/main/java/org/apache/tez/dag/history/events/AMLaunchedEvent.java:
##########
@@ -90,7 +91,7 @@ public void toProtoStream(CodedOutputStream outputStream) throws IOException {
 
   @Override
   public void fromProtoStream(CodedInputStream inputStream) throws IOException {
-    AMLaunchedProto proto = inputStream.readMessage(AMLaunchedProto.PARSER, null);
+    AMLaunchedProto proto = inputStream.readMessage(AMLaunchedProto.parser(), ExtensionRegistry.newInstance());

Review Comment:
   thanks @mbathori-cloudera, I think now we can move on with PARSER (even if it's deprecated), as we haven't decided about a major tez release yet, so backward compatibility now looks more important to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org