[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #583: Replacing Apache commons-lang3 object serializer with Kryo serializer

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #583: Replacing Apache commons-lang3 object serializer with Kryo serializer
URL: https://github.com/apache/incubator-hudi/pull/583#discussion_r266569603
 
 

 ##########
 File path: hoodie-common/src/main/java/com/uber/hoodie/common/util/SerializationUtils.java
 ##########
 @@ -166,6 +71,33 @@ public static void serialize(final Serializable obj, final OutputStream outputSt
     if (objectData == null) {
       throw new IllegalArgumentException("The byte[] must not be null");
     }
-    return deserialize(new ByteArrayInputStream(objectData));
+    return (T) serializerRef.get().deserialize(objectData);
+  }
+
+  private static class KryoSerializerInstance implements Serializable {
+    public static final int KRYO_SERIALIZER_BUFFER_SIZE = 1048576;
 
 Review comment:
   @ovj qq.. does this buffer grow if large objects come along? is this just an intial size? if so, can you rename the variable as well. if not, do we need to expose a parameter for this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services